From fd5aa79f8d9136d9d30c630a1d654d09e2795621 Mon Sep 17 00:00:00 2001 From: Yutong Zhang <90831468+yutongzhang-microsoft@users.noreply.github.com> Date: Tue, 21 Jan 2025 09:52:54 +0800 Subject: [PATCH] [Impacted Area Based PR testing] Deprecate old PR checkers. (#16589) After rolling out all of the new PR checkers, the old PR checkers are no longer needed. We decide to phase them out gradually. In this PR, we phase out the PR checker t0-2vlans, t0-sonic, t1-multi-asic, dpu and dualtor. What is the motivation for this PR? After rolling out all of the new PR checkers, the old PR checkers are no longer needed. We decide to phase them out gradually. In this PR, we phase out the PR checker t0-2vlans, t0-sonic, t1-multi-asic, dpu and dualtor. How did you do it? Deprecate the old PR checkers and make the new PR checkers as mandatory. How did you verify/test it? Test by pipeline itself, to see if we can successfully finish the pipeline. --- azure-pipelines.yml | 103 +++++--------------------------------------- 1 file changed, 10 insertions(+), 93 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 0b243aedc0..dcdabc4fb3 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -109,13 +109,13 @@ stages: STOP_ON_FAILURE: "False" - job: impacted_area_t0_2vlans_elastictest - displayName: "impacted-area-kvmtest-t0_2vlans by Elastictest - optional" + displayName: "impacted-area-kvmtest-t0_2vlans by Elastictest" dependsOn: get_impacted_area condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], 't0-2vlans_checker') variables: TEST_SCRIPTS: $[ dependencies.get_impacted_area.outputs['SetVariableTask.TEST_SCRIPTS'] ] timeoutInMinutes: 240 - continueOnError: true + continueOnError: false pool: sonic-ubuntu-1c steps: - template: .azure-pipelines/impacted_area_testing/calculate-instance-numbers.yml @@ -132,7 +132,6 @@ stages: DEPLOY_MG_EXTRA_PARAMS: "-e vlan_config=two_vlan_a" KVM_IMAGE_BRANCH: $(BUILD_BRANCH) MGMT_BRANCH: "master" - STOP_ON_FAILURE: "False" - job: impacted_area_t1_lag_elastictest displayName: "impacted-area-kvmtest-t1-lag by Elastictest - optional" @@ -160,13 +159,13 @@ stages: STOP_ON_FAILURE: "False" - job: impacted_area_dualtor_elastictest - displayName: "impacted-area-kvmtest-dualtor by Elastictest - optional" + displayName: "impacted-area-kvmtest-dualtor by Elastictest" dependsOn: get_impacted_area condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], 'dualtor_checker') variables: TEST_SCRIPTS: $[ dependencies.get_impacted_area.outputs['SetVariableTask.TEST_SCRIPTS'] ] timeoutInMinutes: 240 - continueOnError: true + continueOnError: false pool: sonic-ubuntu-1c steps: - template: .azure-pipelines/impacted_area_testing/calculate-instance-numbers.yml @@ -183,16 +182,15 @@ stages: COMMON_EXTRA_PARAMS: "--disable_loganalyzer " KVM_IMAGE_BRANCH: $(BUILD_BRANCH) MGMT_BRANCH: "master" - STOP_ON_FAILURE: "False" - job: impacted_area_multi_asic_elastictest - displayName: "impacted-area-kvmtest-multi_asic by Elastictest - optional" + displayName: "impacted-area-kvmtest-multi_asic by Elastictest" dependsOn: get_impacted_area condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], 't1-multi-asic_checker') variables: TEST_SCRIPTS: $[ dependencies.get_impacted_area.outputs['SetVariableTask.TEST_SCRIPTS'] ] timeoutInMinutes: 240 - continueOnError: true + continueOnError: false pool: sonic-ubuntu-1c steps: - template: .azure-pipelines/impacted_area_testing/calculate-instance-numbers.yml @@ -209,16 +207,15 @@ stages: NUM_ASIC: 4 KVM_IMAGE_BRANCH: $(BUILD_BRANCH) MGMT_BRANCH: "master" - STOP_ON_FAILURE: "False" - job: impacted_area_sonic_t0_elastictest - displayName: "impacted-area-kvmtest-sonic_t0 by Elastictest - optional" + displayName: "impacted-area-kvmtest-sonic_t0 by Elastictest" dependsOn: get_impacted_area condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], 't0-sonic_checker') variables: TEST_SCRIPTS: $[ dependencies.get_impacted_area.outputs['SetVariableTask.TEST_SCRIPTS'] ] timeoutInMinutes: 240 - continueOnError: true + continueOnError: false pool: sonic-ubuntu-1c steps: - template: .azure-pipelines/impacted_area_testing/calculate-instance-numbers.yml @@ -236,16 +233,15 @@ stages: COMMON_EXTRA_PARAMS: "--neighbor_type=sonic " VM_TYPE: vsonic MGMT_BRANCH: "master" - STOP_ON_FAILURE: "False" - job: impacted_area_dpu_elastictest - displayName: "impacted-area-kvmtest-dpu by Elastictest - optional" + displayName: "impacted-area-kvmtest-dpu by Elastictest" dependsOn: get_impacted_area condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], 'dpu_checker') variables: TEST_SCRIPTS: $[ dependencies.get_impacted_area.outputs['SetVariableTask.TEST_SCRIPTS'] ] timeoutInMinutes: 240 - continueOnError: true + continueOnError: false pool: sonic-ubuntu-1c steps: - template: .azure-pipelines/impacted_area_testing/calculate-instance-numbers.yml @@ -261,7 +257,6 @@ stages: MAX_WORKER: $(INSTANCE_NUMBER) KVM_IMAGE_BRANCH: $(BUILD_BRANCH) MGMT_BRANCH: "master" - STOP_ON_FAILURE: "False" # Below is the original PR checkers - job: t0_elastictest @@ -278,22 +273,6 @@ stages: KVM_IMAGE_BRANCH: $(BUILD_BRANCH) MGMT_BRANCH: "master" - - job: t0_2vlans_elastictest - displayName: "kvmtest-t0-2vlans by Elastictest" - timeoutInMinutes: 240 - continueOnError: false - pool: sonic-ubuntu-1c - steps: - - template: .azure-pipelines/run-test-elastictest-template.yml - parameters: - TOPOLOGY: t0 - TEST_SET: t0-2vlans - MIN_WORKER: $(T0_2VLANS_INSTANCE_NUM) - MAX_WORKER: $(T0_2VLANS_INSTANCE_NUM) - DEPLOY_MG_EXTRA_PARAMS: "-e vlan_config=two_vlan_a" - KVM_IMAGE_BRANCH: $(BUILD_BRANCH) - MGMT_BRANCH: "master" - - job: t1_lag_elastictest displayName: "kvmtest-t1-lag by Elastictest" timeoutInMinutes: 240 @@ -308,68 +287,6 @@ stages: KVM_IMAGE_BRANCH: $(BUILD_BRANCH) MGMT_BRANCH: "master" - - job: dualtor_elastictest - displayName: "kvmtest-dualtor-t0 by Elastictest" - timeoutInMinutes: 240 - continueOnError: false - pool: sonic-ubuntu-1c - steps: - - template: .azure-pipelines/run-test-elastictest-template.yml - parameters: - TOPOLOGY: dualtor - MIN_WORKER: $(T0_DUALTOR_INSTANCE_NUM) - MAX_WORKER: $(T0_DUALTOR_INSTANCE_NUM) - COMMON_EXTRA_PARAMS: "--disable_loganalyzer " - KVM_IMAGE_BRANCH: $(BUILD_BRANCH) - MGMT_BRANCH: "master" - - - job: multi_asic_elastictest - displayName: "kvmtest-multi-asic-t1-lag by Elastictest" - timeoutInMinutes: 240 - continueOnError: false - pool: sonic-ubuntu-1c - steps: - - template: .azure-pipelines/run-test-elastictest-template.yml - parameters: - TOPOLOGY: t1-8-lag - TEST_SET: multi-asic-t1-lag - MIN_WORKER: $(MULTI_ASIC_INSTANCE_NUM) - MAX_WORKER: $(MULTI_ASIC_INSTANCE_NUM) - NUM_ASIC: 4 - KVM_IMAGE_BRANCH: $(BUILD_BRANCH) - MGMT_BRANCH: "master" - - - job: sonic_t0_elastictest - displayName: "kvmtest-t0-sonic by Elastictest" - timeoutInMinutes: 240 - continueOnError: false - pool: sonic-ubuntu-1c - steps: - - template: .azure-pipelines/run-test-elastictest-template.yml - parameters: - TOPOLOGY: t0-64-32 - MIN_WORKER: $(T0_SONIC_INSTANCE_NUM) - MAX_WORKER: $(T0_SONIC_INSTANCE_NUM) - TEST_SET: t0-sonic - COMMON_EXTRA_PARAMS: "--neighbor_type=sonic " - VM_TYPE: vsonic - KVM_IMAGE_BRANCH: $(BUILD_BRANCH) - MGMT_BRANCH: "master" - - - job: dpu_elastictest - displayName: "kvmtest-dpu by Elastictest" - timeoutInMinutes: 240 - continueOnError: false - pool: sonic-ubuntu-1c - steps: - - template: .azure-pipelines/run-test-elastictest-template.yml - parameters: - TOPOLOGY: dpu - MIN_WORKER: $(T0_SONIC_INSTANCE_NUM) - MAX_WORKER: $(T0_SONIC_INSTANCE_NUM) - KVM_IMAGE_BRANCH: $(BUILD_BRANCH) - MGMT_BRANCH: "master" - - job: onboarding_elastictest_t0 displayName: "onboarding t0 testcases by Elastictest - optional" timeoutInMinutes: 240