Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the scancode toolkit for check license function #27

Closed
techytushar opened this issue Apr 2, 2018 · 1 comment
Closed

Use the scancode toolkit for check license function #27

techytushar opened this issue Apr 2, 2018 · 1 comment

Comments

@techytushar
Copy link
Collaborator

As suggested by @pombredanne using the scancode-toolkit for check license function would be better, instead of using the Java function and it is also in the TODO list. @goneall @rtgdk Please give your views

@goneall
Copy link
Member

goneall commented Apr 2, 2018

I don't believe that Scancode complies with the SPDX license matching guidelines. Since this is an SPDX tool, the license matching should comply with the guidelines. If Scancode does not comply, the Java tools should be used to fully check if license text matches.

There is, however, a performance issue with any tool fully complying with the license matching guidelines especially when used to check against a large number of possible license matches.

Using the Scancode to narrow down the possible license matches and then calling the Java code could improve the performance while retaining the accuracy of implementing the matching guidelines.

There is an issue tracking the performance of the Java tools here: spdx/tools#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants