Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarChart customization and ASCII support. #1735

Open
Charanor opened this issue Jan 17, 2025 · 2 comments
Open

BarChart customization and ASCII support. #1735

Charanor opened this issue Jan 17, 2025 · 2 comments

Comments

@Charanor
Copy link

Looking at the source code BarChart overrides its ProgressBar's AsciiBar property with a non-ASCII character: . I suggest keeping it as ProgressBar's default (-) and also adding support to BarChart to change the bar character:

// Override all bars
new BarChart().Bar('+');
// Override bars separately
new BarChart().Bar(unicodeBar: '█', asciiBar: '+');
@Charanor Charanor added bug Something isn't working needs triage labels Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Todo 🕑 in Spectre Console Jan 17, 2025
@patriksvensson patriksvensson added feature and removed bug Something isn't working labels Jan 17, 2025
@patriksvensson
Copy link
Contributor

The is part of extended ASCII (219) and part of most code pages, so it should be fine.

@Charanor
Copy link
Author

The is part of extended ASCII (219) and part of most code pages, so it should be fine.

I'm using Spectre.Console on a Telnet server (for a MUD) to send pretty text and there are clients that can only handle 7-bit ASCII so unfortunately not for my use case 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo 🕑
Development

No branches or pull requests

2 participants