Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some queries bypass Lada Cache #84

Open
spiritix opened this issue Dec 18, 2019 · 3 comments
Open

Some queries bypass Lada Cache #84

spiritix opened this issue Dec 18, 2019 · 3 comments

Comments

@spiritix
Copy link
Owner

spiritix commented Dec 18, 2019

After some comprehensive testing, I figured out, that since Laravel 6 there are some queries that bypass Lada Cache. This doesn't cause unexpected behavior but reduces the effect of the cache. If used with Debug Bar, the "Queries" tab must not show any queries after the second page load. All queries which are still shown bypass the cache.

@xwiz
Copy link
Contributor

xwiz commented Jun 2, 2020

@spiritix How do we know it's not the debug bar that's having the error? If I remember correctly I noticed activity on redis monitor cli while the debug bar didn't seem to change behaviour, but I'll take a look at this again to verify.

@spiritix
Copy link
Owner Author

spiritix commented Jun 2, 2020

@xwiz First, this seems to be edge case that only occurs with very complex and rare queries. It's not like a large portion of the queries would bypass the cache. But then to your question - indeed, we'd need to verify that this is not a Debug Bar issue. Theoretically, a query that is being handled by Lada Cache is obviously not executed against the database backend but instead routed via the cache. So the Debug Bar should not be able to even access it.

@xwiz
Copy link
Contributor

xwiz commented Jun 2, 2020

I agree, it may well be that it's able to capture certain queries at some other method in version 6.x which LadaCache does not override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants