Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom property values do not support hyphens #48

Closed
bambro opened this issue May 13, 2024 · 1 comment · Fixed by #49
Closed

Custom property values do not support hyphens #48

bambro opened this issue May 13, 2024 · 1 comment · Fixed by #49
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bambro
Copy link
Contributor

bambro commented May 13, 2024

Description:
This issue extends from issue #40 to support hyphens in the custom property value, similar to the support that was added in for the key.

Currently the regex only supports alphanumeric characters and underscores with the following regex /^[a-zA-Z0-9](\w|_){1,128}$ and should be extended to /^[a-zA-Z0-9](\w|-|_){1,128}$.

Additional Information:

@greatestusername-splunk
Copy link
Collaborator

Good catch! Thought the hyphen had gotten into all of them in 40!
Are you at all interested in contributing a quick PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants