-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate this repo into Spring Integration repo #254
Comments
Example for how unmaintained this project is, and why this is so confusing and misleading - this project references the AWS and the Kafka connector, just for a README that will tell the user that this connector isn't in this repo. This repo of course has some other connectors like Twitter, but it won't reference that in the README. @artembilan Please migrate this and improve this project for the next user. |
Thanks for bring this up, @ipanimnim . We already such a discussion in other place: spring-projects/spring-integration#3720. Feel free to continue over there. |
@artembilan The discussion we had there was out of subject (the issue was about the request for more extensions in general). This issue seems to fit more. Anyway, was there any progress in this subject since the last discussion? |
Thanks, @almogtavor , for the pointer. As I always say, the contribution is welcome: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc |
@artembilan would you accept PRs that will move this & other repos like |
Not yet. At a glance only Cassandra, Hazelcast, Zip, SMB are good to go. Although I may confirm fully that Goovy DSL is 100% candidate to go into Thanks |
Why AWS is based on spring boot? About GCP, Alibaba and so, their fine as long as being referenced from the docs. All the others that are relevant should be in the same place, which should encourage to add more connectors over time. |
Please, they are not called connectors. They are channel adapters. That's exactly a canonical name from EIP: https://www.enterpriseintegrationpatterns.com/patterns/messaging/ChannelAdapter.html. The Spring Integration AWS uses Spring Cloud AWS , which is based on Spring Cloud, which, in turn, is based on Spring Boot. And the last one exactly uses Spring Integration. Therefore Spring Integration AWS has to be the last one in the release train. |
How does the AWS module different from the Mongo module? They both rely on other Spring based projects. And in general the main point is that all of the channel adapters that can sit in the main repo, should sit there. Otherwise, at least to be documented on the main docs/ referenced from the main docs. |
There is a difference to be dependent on a plain Spring module and the one based on Spring Boot. The auto-configuration from Spring Boot and Spring Cloud rely changes a play over here. |
I think the AWS channel adapters should stay at their own repo (as long as being referenced from the official SI docs - which they currently do not). When it comes to channel adapters for Twitter, Cassandra, and more, I think they have to be in the SI official repo, and as fast as possible, since people don't know of them and think that they just don't exist (which happened to me). @artembilan would you accept a copy-paste PR that moves the following folders:
I think this is also a good chance to merge back:
I think this move is no less than a must. These extensions don't even appear in the table, their docs don't appear in the main docs, and nobody actually has an opportunity to know about them. |
We cannot move twitter back because we really have moved it here for the reason its base library was EoL: https://spring.io/blog/2018/07/03/spring-social-end-of-life-announcement. It can come back only if there is other library we can make channel adapters based on. The We cannot move I doubt in I doubt it is going to be just easy copy/paste PRs. As I said before: the Groovy DSL is the best candidate to go. So, let's start from it for now! |
So:
Seems good? |
I think so. Let’s see how it goes! |
@artembilan Me again... I have a branch ready for the SMB extension to be migrated into the main Spring Integration repo that is ready for your review. Let me know if I can create a PR for it, or whether you would like me to hold off. Thanks! |
Sounds good, @GregBragg ! Just open a PR in https://github.com/spring-projects/spring-integration and we will proceed from there with details if any! Thanks |
The Big thanks to @GregBragg ! |
Opinion - this repo is redundant, confusing, looks unmaintained, and encourages people to not contribute new Spring Integrations Connectors (since these connectors won't enter the Spring Integration project, and instead enter an unknown and undocumented one).
I don't see any advantage to this, and as a relatively new user, I'm just getting more and more confused by this whole thing.
The text was updated successfully, but these errors were encountered: