Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kotlin DSL webAuthn { } #16338

Closed
franticticktick opened this issue Dec 23, 2024 · 0 comments
Closed

Fix Kotlin DSL webAuthn { } #16338

franticticktick opened this issue Dec 23, 2024 · 0 comments
Assignees
Labels
in: config An issue in spring-security-config type: bug A general bug
Milestone

Comments

@franticticktick
Copy link
Contributor

WebAuthnDsl is implemented incorrectly, we need to change the implementation of the get() method according to the usual spring security template, as in other kotlin DSLs. Now, due to incorrect implementation, the default configuration will not work.

        @Bean
        open fun securityFilterChain(http: HttpSecurity): SecurityFilterChain {
            http{
                formLogin { }
                webAuthn { }
            }
            return http.build()
        }

In addition, the DSL is missing disableDefaultRegistrationPage.

@franticticktick franticticktick added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Dec 23, 2024
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 23, 2024
franticticktick added a commit to franticticktick/spring-security that referenced this issue Jan 11, 2025
Closes spring-projectsgh-16338

Signed-off-by: Max Batischev <mblancer@mail.ru>
@rwinch rwinch changed the title Incorrect kotlin webauthn configuration Fix WebAuthn Kotlin DSL for default configuration Jan 13, 2025
@rwinch rwinch self-assigned this Jan 13, 2025
@rwinch rwinch added in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2025
@rwinch rwinch added this to the 6.4.3 milestone Jan 13, 2025
@rwinch rwinch changed the title Fix WebAuthn Kotlin DSL for default configuration Fix Kotlin DSL webAuthn {} Jan 13, 2025
@rwinch rwinch changed the title Fix Kotlin DSL webAuthn {} Fix Kotlin DSL webAuthn { } Jan 13, 2025
@rwinch rwinch closed this as completed in 882766e Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants