Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Material in pinocchio::GeometryObject #2084

Closed
jorisv opened this issue Nov 13, 2023 Discussed in #2079 · 1 comment · Fixed by #2119
Closed

Add Material in pinocchio::GeometryObject #2084

jorisv opened this issue Nov 13, 2023 Discussed in #2079 · 1 comment · Fixed by #2119
Assignees

Comments

@jorisv
Copy link
Contributor

jorisv commented Nov 13, 2023

pinocchio::GeometryObject already hold renderer information (texture path, color).
Since a lot of renderer ask for Material, it can be nice to add it.

Material definition in OpenGL

Discussed in #2079

@jorisv jorisv self-assigned this Nov 13, 2023
@jorisv jorisv linked a pull request Dec 13, 2023 that will close this issue
@jorisv
Copy link
Contributor Author

jorisv commented Dec 18, 2023

Closed by #2119

@jorisv jorisv closed this as completed Dec 18, 2023
nim65s added a commit to nim65s/robotpkg that referenced this issue Jan 27, 2024
Upstream changes:

    ## [2.7.0] - 2024-01-23

    ### Added
    - Add `GeometryObject::meshMaterial` attribute (stack-of-tasks/pinocchio#2084)

    ### Fixed

    - Use bp::ssize_t for recent version of Windows compilers (stack-of-tasks/pinocchio#2102)
    - Fix missing include for Boost >= 1.83 (stack-of-tasks/pinocchio#2103)
    - Remove f-strings to fix install with python 2 (stack-of-tasks/pinocchio#2110)
    - CMake: stop exporting CppAd/cppadcodegen & fetch submodule if not available (stack-of-tasks/pinocchio#2112)
    - Fix malloc issue in CRBA algo (stack-of-tasks/pinocchio#2126)
    - Fix build cppad and cppadcg with Boost < 1.77 (stack-of-tasks/pinocchio#2132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant