Parser issue for long quotes

[mytmark]

Thank you very much for this great extension. I found one little issue with long quotes. Your parser would recognize a single quote as the end of a long quote. Example:

:Bens_house dc:description '''Ben's house'''@en .

This triple is conform to RDF grammar (https://www.w3.org/TR/turtle/#grammar-production-STRING_LITERAL_LONG_SINGLE_QUOTE).

Best regards,
Mark

[jmrog]

I think the parser actually gets this correct, strictly speaking (see image below). I think the only thing that is incorrect is the syntax highlighting (i.e., the textmate grammar for Turtle). We can try to fix that at some point soon, or PRs are welcome in the meantime! Thanks.

[mytmark]

I am sorry, but i do not know how to do a pull request, I'm not allowed to push to your repository which I seem to have to do in order to do a pull request. But I found the bug: In the turtle.tmLanguage.json file simply change the order of string patterns. Instead of

    { "include": "#single-squote-string-literal" },
    { "include": "#single-dquote-string-literal" },
    { "include": "#triple-squote-string-literal" },
    { "include": "#triple-dquote-string-literal" },
    { "include": "#triple-tick-string-literal" }

write

    { "include": "#triple-squote-string-literal" },
    { "include": "#triple-dquote-string-literal" },
    { "include": "#triple-tick-string-literal" },
    { "include": "#single-squote-string-literal" },
    { "include": "#single-dquote-string-literal" }

That should do the trick. Hope this helps and maybe you got some advice how to do a proper pull request for a github-noob like me :)

Best regards,
Mark

[fkleedorfer]

I can confirm this problem in 0.1.2:

[jmrog]

I am sorry, but i do not know how to do a pull request, I'm not allowed to push to your repository which I seem to have to do in order to do a pull request. But I found the bug: In the turtle.tmLanguage.json file simply change the order of string patterns. Instead of

    { "include": "#single-squote-string-literal" },
    { "include": "#single-dquote-string-literal" },
    { "include": "#triple-squote-string-literal" },
    { "include": "#triple-dquote-string-literal" },
    { "include": "#triple-tick-string-literal" }

write

    { "include": "#triple-squote-string-literal" },
    { "include": "#triple-dquote-string-literal" },
    { "include": "#triple-tick-string-literal" },
    { "include": "#single-squote-string-literal" },
    { "include": "#single-dquote-string-literal" }

That should do the trick. Hope this helps and maybe you got some advice how to do a proper pull request for a github-noob like me :)

Best regards,
Mark

@mytmark Thanks for this. You can make a pull request to this repo by forking the repo (to your own GitHub), creating a branch on your fork and pushing your code to that branch, then opening a pull request from your fork to our repository. The flow is described in more detail here: https://jarv.is/notes/how-to-pull-request-fork-github/

If you'd rather not do this, we can make the change you suggested. But making a pull request is a nice way to get credit!