Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate report job takes too long #262

Closed
stuartcusackie opened this issue Feb 3, 2023 · 6 comments
Closed

Generate report job takes too long #262

stuartcusackie opened this issue Feb 3, 2023 · 6 comments
Assignees

Comments

@stuartcusackie
Copy link

stuartcusackie commented Feb 3, 2023

My reports won't complete on a site with 400 entries. I am using the Redis queue with Horizon at the default of 60 second timeouts:

image

I think ideally these jobs should be split (one entry per job). A job that takes 10 minutes to run seems like a bad idea, and this site isn't really that big compared to some.

If that's not happening then a simpler improvement would be a customisable queue in the config. At the moment the only option is to massively increase the timeout of all jobs on the default queue, which I don't like doing.

Thanks!

@stuartcusackie
Copy link
Author

stuartcusackie commented Feb 3, 2023

I have increased all jobs to 120 seconds and still it fails:
image

I have now increased jobs to 300 seconds and it still looks like it is going to fail.
image

@rubzie
Copy link

rubzie commented Oct 18, 2023

We're experiencing comparable issues, hope it can be addressed! 🙏🏼

@jesseleite
Copy link
Member

@stuartcusackie @rubzie, some pretty big performance improvements coming in the next release #304 and #307, with more improvements yet to come...

My reports won't complete on a site with 400 entries

For example, I'm now generating a report for 1000 entries, without a queue even set up, in ~8.5 seconds...

CleanShot 2023-12-12 at 16 35 33

@rubzie
Copy link

rubzie commented Dec 21, 2023

@stuartcusackie @rubzie, some pretty big performance improvements coming in the next release #304 and #307, with more improvements yet to come...

Wooohoo nice, looking forward to it, thanks a lot @jesseleite! Then onto the next challenge, making SEO Pro work for multi site ;)

@jesseleite
Copy link
Member

Will close this when we tag next version, but see #310 🏎️

@jesseleite
Copy link
Member

Tagged 5.4.0 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants