Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApps - improve eth_signTransaction handling #17009

Open
virginiabalducci opened this issue Dec 23, 2024 · 0 comments
Open

dApps - improve eth_signTransaction handling #17009

virginiabalducci opened this issue Dec 23, 2024 · 0 comments
Assignees
Milestone

Comments

@virginiabalducci
Copy link

Description

The eth_signTransaction is not supported by the Status App.

Metrics

Related to #16912

Some metrics triggers for the eth_signTransaction method:

  • an eth_signTransaction request is received -> metric triggers correctly upon receiving the request
  • an eth_signTransaction request is accepted -> since the Status desktop app does not support accepting this type of transaction, it is automatically rejected when tried to accept it.
  • an eth_signTransaction request is rejected -> metric triggers correctly upon rejecting

Acceptance Criteria

This AC cannot be triggered because the Status app will always reject these transactions.

Given a sign/transaction request is accepted
Then a new dapps-sign event is sent and the following properties are filled
flow=sign_accepted
connector - wallet_connect or browser_connect
method - signing method: eth_signTransaction
chainId - chain id
dapp - dapp URL

When trying to accept this, the metric that triggers is the reject one, which is correct.

Given a sign/transaction request is rejected
Then a new dapps-sign event is sent and the following properties are filled
flow=sign_rejected
connector - wallet_connect or browser_connect
method - signing method eth_signTransaction
chainId - chain id
dapp - dapp URL

You can test at https://se-sdk-dapp.vercel.app/

It's rejected when trying to sign the request using the eth_signTransaction method, and an error message is displayed. We should find a better way to handle the error, specifying the method and the dApp used. It would be nice to have a better error message since right now, we see the following:

error:
Rejecting due to error

Image

https://eu.mixpanel.com/project/3350627/view/3857659/app/events#kG8M2voqqmE4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants