Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Advanced Settings #21896

Open
ilmotta opened this issue Jan 7, 2025 · 0 comments
Open

Redo Advanced Settings #21896

ilmotta opened this issue Jan 7, 2025 · 0 comments
Labels
feature feature requests mobile-core
Milestone

Comments

@ilmotta
Copy link
Contributor

ilmotta commented Jan 7, 2025

Feature Issue

In the Profile Settings, sections Advanced and Legacy settings are using the old UI components. We want to redesign them according to new design system & code standards.

Further analysis about individual settings are in this issue #21360, which should be closed alongside this one. Both issues are complementary, this one serves the purpose of the UI/UX aspect and #21360 was more of an investigative issue about functionality.

Resolving this issue also means closing #20490.

Notes

As defined in Figma (screenshot below), the Advanced settings don't require designs in Figma since they are rarely used by users. Some settings are almost exclusively used by core contributors.

Nonetheless, some settings make no sense anymore, navigation is broken, and there's no explanation about what these settings do.

Acceptance Criteria

There's some freedom to work on this issue since we are not bound by designs in Figma, but we should stick to the simplest possible solutions because we can't dedicate too much time to this issue. We do have some criteria:

About Legacy settings section:

  • Legacy settings > Sync settings > Devices is removed and not moved to the new Advanced settings screen.
  • Legacy settings > Sync settings > Status nodes is removed and not moved to the new Advanced settings screen.
  • Legacy settings > Sync settings: Sync history for and Backup settings options are moved to the new Advanced settings screen.
  • Finally, the entire Legacy settings section is removed from the profile settings screen.

About the new Advanced section:

In this section, we want certain options to have a description. Nowadays the user is left to guess what they mean, e.g. the option Light client is only obvious for those with context. The component below (see Figma) is such a component that supports this use case. There are many other variations which we can decide to use.

The exact description about settings and which ones to describe and what text is an exercise left for the developer assigned to this issue. We expect this issue to be updated by the dev after aligning with more devs and before opening the PR(s).

We should consider grouping certain settings as well, as exemplified here:

Priority

Priority is considered low compared to all the rest, but is considered higher priority than simple cosmetic issues (which we have many) because this issue does affect the user experience. Therefore, this issue should be preferred instead of cosmetic issues for milestone 2.33. This issue can be split into more than one PR if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests mobile-core
Projects
Status: No status
Development

No branches or pull requests

1 participant