Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License ledger should be isolated as a non fungible token #706

Open
3esmit opened this issue Feb 25, 2020 · 1 comment
Open

License ledger should be isolated as a non fungible token #706

3esmit opened this issue Feb 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@3esmit
Copy link
Member

3esmit commented Feb 25, 2020

Feature Request

In case of upgrade on License.sol, the change of License.sol, the migration would be required. To don't require migrations, isolate the owners of licenses in a separate (probably ERC721) token.

Summary

Licenses would be created by a controlling contract, which contains the logic for how license token is generated or destroyed, but they are stored in chain and managed by the users as a NFT in a dedicated address. The contract managing the sell of licenses would change controller of the NFT on a migration, so the new license market logic would own the token, making the upgrade seamless for existent users and contracts relaying on the verification of this token.

@3esmit 3esmit added the enhancement New feature or request label Feb 25, 2020
@richard-ramos
Copy link
Member

I'm not sure of this enhancement. Under what conditions would a migration be required?
Currently the licenses are handled as a mapping, and to determine if a user has a license, we check if that mapping has a value for the user address. Doing an upgrade should not affect the state of this variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants