Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Braces can sometimes be misaligned on fix #6

Open
d4mation opened this issue Jun 20, 2024 · 0 comments
Open

Closing Braces can sometimes be misaligned on fix #6

d4mation opened this issue Jun 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@d4mation
Copy link
Contributor

d4mation commented Jun 20, 2024

/**
 * Tests that get_instructor_list() returns the expected output.
 *
 * @return void
 */
public function test_get_instructor_list(): void {
	// Arrange.

	// Act.

	$response = $this->instance->get_instructor_list( new WP_REST_Request() );

	// Assert.

	if ( is_wp_error( $response ) ) {
		$this->fail( $response->get_error_message() );
	}

	if ( ! $response instanceof WP_REST_Response ) {
		$this->fail( 'Something caused neither a WP_Error or a WP_REST_Response object to be returned' );
	}
		
}

Will currently result in this:

/**
 * Tests that get_instructor_list() returns the expected output.
 *
 * @return void
 */
public function test_get_instructor_list(): void {
	// Arrange.

	// Act.

	$response = $this->instance->get_instructor_list( new WP_REST_Request() );

	// Assert.

	if ( is_wp_error( $response ) ) {
		$this->fail( $response->get_error_message() );
	}

	if ( ! $response instanceof WP_REST_Response ) {
		$this->fail( 'Something caused neither a WP_Error or a WP_REST_Response object to be returned' );
	}   }

Somehow, that tab is being converted to spaces and causing a misalignment. Need to investigate further.

Note: This happens both on v1.1.1 and v1.1.2 and possibly older versions. This may have always been an issue.

@d4mation d4mation added the bug Something isn't working label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant