Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip instead of injecting text directly. #1

Open
nicolasgramlich opened this issue Jan 6, 2014 · 7 comments
Open

Tooltip instead of injecting text directly. #1

nicolasgramlich opened this issue Jan 6, 2014 · 7 comments

Comments

@nicolasgramlich
Copy link

It would be great to have the balance/etc... in form of a tooltip/popup instead of injecting the balance text directly. Ideally (maybe with an option in the settings) it would automatically pop up when hovering over the icon.

@steven2358
Copy link
Owner

Several people are actually asking for this feature, so I've put it on top of the to-do list. But I don't know yet when I'll be able to work on it.

@steven2358
Copy link
Owner

For the record, this can be done nicely with the dialog HTML element http://demo.agektmr.com/dialog/

@dawsbot
Copy link
Contributor

dawsbot commented Jul 23, 2015

I'll be working on this soon. Would it be preferred to leave the icon as well? I often notice the extension because of the icon that appears, so removing that may be a big fault. Perhaps adding the same text that gets injected upon button click to a tooltip for the address?

@steven2358
Copy link
Owner

I was thinking of a display chooser in the options screen that lets you choose between standard behavior (as it is right now) and tooltip. The tooltip would be as you describe: upon clicking the icon it shows the info in a tooltip.

I would leave the icon for the moment being. Hiding it could be a third option, but it becomes tricky since often the BTC addresses are links and it wouldn't be clear where you'd have to click.

@steven2358
Copy link
Owner

On second thought: the tooltip could appear on hovering over the icon, as suggested by @nicolasgramlich And if the icon is hidden, it could appear on hovering over the address. The hovering avoids one click hence is faster.

@dawsbot
Copy link
Contributor

dawsbot commented Jul 23, 2015

So keep the icon, and have the tooltip extend from the icon itself? I like that idea, and it would be less buggy to implement than creating options. So this would disable the "clickability" of the button as well?

@steven2358
Copy link
Owner

At this point there are too many possibilities:

  1. inline or tooltip
  2. click or hover
  3. show icon or not

That's 8 possible combinations. I was thinking of using a simple options screen to choose between two possibilities:

  1. inline with click on icon (current behavior)
  2. tooltip on hovering over icon

It shouldn't be too difficult to implement options, I have done this for other other extensions (e.g. options.html and options.js here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants