Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork shader-compiler and add yuzu upstream fixes #151

Open
gameblabla opened this issue Aug 3, 2023 · 4 comments
Open

Fork shader-compiler and add yuzu upstream fixes #151

gameblabla opened this issue Aug 3, 2023 · 4 comments
Labels

Comments

@gameblabla
Copy link

We are still using the repo from skyline's org, we should fork it obviously.
There are issues with shader-compiler as it's missing a few fixes.

For example on adreno 6xx with Turnip drivers in Fire Emblem engage when a character on the field gets highlighted and talks, it crashes.
Turns out the crash was caused by : gameblabla/shader-compiler@5126503
I forked your repo and shader-compiler with the fix in place and can confirm it no longer crashes.

There's also stuff like the Tears of the Kingdom fix : gameblabla/shader-compiler@299ad9a but i did not try this game and i'm not even sure it even boots on strato.

I could do a PR but it would be preferable if you create the repo for shader-compiler and do it.

@nickbeth
Copy link
Member

nickbeth commented Aug 7, 2023

Thanks for looking into this, I'll create the fork under the Strato organization soon.

@Crytonics Crytonics added the todo label Aug 12, 2023
@Crytonics
Copy link
Contributor

We created Strato's shader-compiler.

@Crytonics Crytonics closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@gameblabla
Copy link
Author

Why was this closed ? The changes you need to merge are pretty trivial (a few couple of lines i might add).

@Crytonics
Copy link
Contributor

I will reopen but i don't think we can use that rn.

@Crytonics Crytonics reopened this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants