Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show the "There is no name sign" option in the places overlay when there is no input field for the name #6086

Open
tiptoptom opened this issue Jan 6, 2025 · 3 comments · May be fixed by #6100
Assignees

Comments

@tiptoptom
Copy link
Contributor

Right now there is all ways the "There is no name sign" option in the places overlay.

  • Also, if the user is not supposed to enter a name.
  • Also, if there is already a name that is not displayed.

I think the "There is no name sign" option should only be shown when also the input field for the name is shown.

@matkoniecz
Copy link
Member

Can you give example of object where this is happening?

@matkoniecz
Copy link
Member

From #6085 it seems to happen with "club=yes and unknown club values"

@mnalis
Copy link
Member

mnalis commented Jan 9, 2025

From #6085 it seems to happen with "club=yes and unknown club values"

Confirmed; e.g. https://www.openstreetmap.org/node/1860127680
That club=yes even already has a name tag recorded, but clicking on it in Places overlay does not show the name (but does have There is no name option).

small_Screenshot_20250109_214017_StreetComplete small_Screenshot_20250109_214030_StreetComplete

Of course, it that case the solution is not removing There is no name but instead displaying missing name field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants