Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not setting a Truststore password results in a NullPointerException #138

Open
adam-long opened this issue Mar 1, 2022 · 1 comment
Open

Comments

@adam-long
Copy link

If a password is not specified for a truststore (or a keystore for that matter), a NullPointerException will occur at io.strimzi.kafka.oauth.common.SSLUtil.createSSLFactory(SSLUtil.java:56).

It's common to not password-protect a truststore (as it just contains certificates that are trusted). In the case of a keystore, if its not desirable to support blank passwords, at the very least an informative error message should be thrown.

@mstruk
Copy link
Contributor

mstruk commented Mar 2, 2022

NPE is always a bug, so that should be fixed. It also makes sense to allow for passwordless truststore.

Thanks for reporting it. Feel free to submit a PR with a proposed fix. In any case, I'll put this on a TODO for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants