Replies: 1 comment 1 reply
-
Sounds great, if it works and it helps you I'm in. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I've setup my favicons disk in filesystems to use s3 driver, but it looks like it's not utilizing it in the GenerateFavicons Listener class. It just grabs the svg with the public_path.
So, I've made an update that uses Storage to get the correct path/url from the favicons disk config.
Tested this with local storage and s3/DO. Works perfectly :)
Would you accept an PR for this?
Greets, Sander
Beta Was this translation helpful? Give feedback.
All reactions