Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use --filterpattern #18

Open
sveetch opened this issue Feb 9, 2020 · 2 comments
Open

Option to use --filterpattern #18

sveetch opened this issue Feb 9, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@sveetch
Copy link
Owner

sveetch commented Feb 9, 2020

It seems usage of --filterpattern option from validator is a useful thing with some stuff like Angular to ignore some required HTML attribute like ng-something="".

This should be a multiple value option, that will be automatically joined (validator expect only one regex).

Think about to add this option to the CLI.

@sveetch sveetch added the enhancement New feature or request label Feb 9, 2020
@sveetch
Copy link
Owner Author

sveetch commented Feb 9, 2020

This is related to old issue #6

@sveetch
Copy link
Owner Author

sveetch commented Feb 10, 2020

Also we may add another new option like --filterpath which could be used to ignore paths from given pattern(s), this should be a multiple value option alike --filterpattern.

'filterpath' will be useful only for site CLI since page CLI paths are manually defined from user.

Finally, these pattern should be a simple string (not regex?) to avoid some path like when a site is written in multiple languages on their own prefix like /fr/foo/ and just need to validate the /en/ pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant