Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Exclude' config is ignored #3

Open
patrickfav opened this issue Jun 4, 2018 · 3 comments
Open

'Exclude' config is ignored #3

patrickfav opened this issue Jun 4, 2018 · 3 comments

Comments

@patrickfav
Copy link

In your README it says

# List of files or directories to exclude
# e.g. custom or hand generated webp conversion files
exclude: []

but it seems it was never implemented:

# TODO: Do an exclude check

@sverrirs
Copy link
Owner

I haven't needed to use this feature. I'd be happy to review a PR if you have the time to implement this?

@patrickfav
Copy link
Author

Alright, you just have to bear with me, ruby is not my strongest suite :)

@sverrirs
Copy link
Owner

No problem, I feel that a technically sound language agnostic solution is superior to any Ruby specific code. We can polish the rubyesque of the code together after ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants