You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
OpsManagerFacade is using Springs @Retryable for one of its methods. In a recent change, the constructor of the MongoDbEnterpriseServiceProvider was changed to instantiate the OpsManagerFacade by calling new OpsManagerFacade() rather than using Springs autowiring. With that the @Retryable annotation is no longer recognized, and the method is therefore not retried anymore in case of failures. Making things worse, there's no test verifying the retries for this method.
Requirements
Verification of retries for the method
Proposal
Add tests for OpsManagerFacade, specifically testing the @Retryable. Ideally done with WireMock.
Fix instantiation of the OpsManagerFacade in MongoDbEnterpriseServiceProvider.
Alternative
Drop using @Retryable and implement another mechanism to retry the failed action.
Problem
OpsManagerFacade
is using Springs@Retryable
for one of its methods. In a recent change, the constructor of theMongoDbEnterpriseServiceProvider
was changed to instantiate the OpsManagerFacade by callingnew OpsManagerFacade()
rather than using Springs autowiring. With that the@Retryable
annotation is no longer recognized, and the method is therefore not retried anymore in case of failures. Making things worse, there's no test verifying the retries for this method.Requirements
Proposal
@Retryable
. Ideally done with WireMock.Alternative
@Retryable
and implement another mechanism to retry the failed action.Links
The text was updated successfully, but these errors were encountered: