Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendorize libcflib #99

Open
CJ-Wright-Citadel opened this issue Apr 28, 2021 · 1 comment
Open

vendorize libcflib #99

CJ-Wright-Citadel opened this issue Apr 28, 2021 · 1 comment

Comments

@CJ-Wright-Citadel
Copy link
Contributor

I think the code is only using the diff part of libcflib, which can be an annoying dep.
@mariusvniekerk
Copy link

simplest approach is probably just to make a pr with a git subtree addition of libcflib. This allows relatively easy updating to the vendored library whilst still allowing for easy updates from upstream which may happen when conda changes some of the formats in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mariusvniekerk @CJ-Wright-Citadel