Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_fastdiff.test_native without wasmer fails on 0.2.0 #3

Open
bollwyvl opened this issue Jul 17, 2019 · 2 comments
Open

test_fastdiff.test_native without wasmer fails on 0.2.0 #3

bollwyvl opened this issue Jul 17, 2019 · 2 comments

Comments

@bollwyvl
Copy link

Over on this build of the conda-forge feedstock for fastdiff, I've come upon:

============================= test session starts ==============================
platform linux -- Python 3.7.3, pytest-3.10.1, py-1.8.0, pluggy-0.12.0
benchmark: 3.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=5.00us max_time=1.00s calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: $SRC_DIR, inifile:
plugins: benchmark-3.0.0, cov-2.7.1
collected 6 items

tests/test_fastdiff.py ..F...                                            [100%]

=================================== FAILURES ===================================
_________________________________ test_native __________________________________

    def test_native():
        compared = compare_native("one\ntwo\nthree", "one\ntwo\nfour")
>       assert compared == ['  one', '  two', '- three', '+ four']
E       AssertionError: assert [] == ['  one', '  two', '- three', '+ four']
E         Right contains more items, first extra item: '  one'
E         Use -v to get the full diff

tests/test_fastdiff.py:31: AssertionError

I haven't had a chance to check it out locally, but will get to it when i have a chance... will at least turn the verbosity up...

@bollwyvl
Copy link
Author

Previous build of 0.1.4...

@bollwyvl bollwyvl changed the title test_fastdiff.test_native fails on 0.2.0 test_fastdiff.test_native without wasmer fails on 0.2.0 Jul 17, 2019
@bollwyvl
Copy link
Author

ah, because compare_native was explicitly set this way in the wasmer-less case (we don't have that just yet on conda-forge):

https://github.com/syrusakbary/fastdiff/blame/21ec63cf2ee0a435314cd18502d369b3aea8d1eb/python/tests/test_fastdiff.py#L15

bors bot added a commit to wasmerio/wasmer-python that referenced this issue Aug 14, 2019
62: Make wasmer silently available anywhere r=Hywan a=syrusakbary

## Problem

Python wasmer installation is failing in various systems (mainly because of alpine linux).
syrusakbary/snapshottest#88
syrusakbary/fastdiff#2
syrusakbary/fastdiff#3

One way to make it work very easily is by creating a generic wheel that it's always available but that fails on import (rather than on install).

This PR adds that, and upgrades wasmer to `0.5.6` as well

Co-authored-by: Syrus <me@syrusakbary.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant