A miss-unlocking bug

[ryancaicse]

Hi, it seems lock best->mutex is missed to be released before line 815. Should it be a bug?

SZ/zstd/dictBuilder/cover.c

Lines 801 to 824 in c30cb79

	ZSTD_pthread_mutex_lock(&best->mutex);
	--best->liveJobs;
	liveJobs = best->liveJobs;
	/* If the new dictionary is better */
	if (compressedSize < best->compressedSize) {
	/* Allocate space if necessary */
	if (!best->dict || best->dictSize < dictSize) {
	if (best->dict) {
	free(best->dict);
	}
	best->dict = malloc(dictSize);
	if (!best->dict) {
	best->compressedSize = ERROR(GENERIC);
	best->dictSize = 0;
	return;
	}
	}
	/* Save the dictionary, parameters, and size */
	memcpy(best->dict, dict, dictSize);
	best->dictSize = dictSize;
	best->parameters = parameters;
	best->compressedSize = compressedSize;
	}
	ZSTD_pthread_mutex_unlock(&best->mutex);

[robertu94]

@ryancaicse this is a bundled version of Zstandard. We don’t really maintain it. Most people who use SZ will install it with a system or spack provided Zstandard rather than this one. If the upstream Zstandard has this same bug fixed, we can look into updating the bundled version

[ryancaicse]

@robertu94 Thank you for your reply. It seems they have fixed it.
https://github.com/facebook/zstd/blob/eadb6c874f9d0c9e90c835f8b0181da802361e4c/lib/dictBuilder/cover.c#L920-L950