Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu and max-x64 executables are missing a dependency #337

Open
jacalata opened this issue Jan 9, 2025 · 3 comments · Fixed by #341
Open

ubuntu and max-x64 executables are missing a dependency #337

jacalata opened this issue Jan 9, 2025 · 3 comments · Fixed by #341

Comments

@jacalata
Copy link
Contributor

jacalata commented Jan 9, 2025

See package validation failures here: https://github.com/tableau/tabcmd/actions/runs/12688585562

Ubuntu:
Run ./dist/ubuntu/tabcmd
[2842] Module object for pyimod02_importers is NULL!
Traceback (most recent call last):
File "PyInstaller/loader/pyimod02_importers.py", line 22, in
File "", line 259, in load_module
File "pathlib.py", line 13, in
File "", line 259, in load_module
File "urllib/parse.py", line 39, in
ModuleNotFoundError: No module named 'ipaddress'
Traceback (most recent call last):
File "PyInstaller/loader/pyiboot01_bootstrap.py", line 17, in
ModuleNotFoundError: No module named 'pyimod02_importers'
[2842] Failed to execute script 'pyiboot01_bootstrap' due to unhandled exception!
Error: Process completed with exit code 1.

@jacalata
Copy link
Contributor Author

Seems a known issue in pyinstaller, except it was fixed in 5.12 and I have 5.13. Maybe the runners have a different version?
pyinstaller/pyinstaller#7692

@jacalata
Copy link
Contributor Author

aha - that fix in pyinstaller is assuming python 3.11 or greater, and we were building on 3.9. Perhaps we should move to building on 3.9 and 3.10 but packaging with 3.11?

https://github.com/pyinstaller/pyinstaller/pull/7694/files
if sys.version_info >= (3, 11, 4): # required by loader/pymod02_importers.py -> pathlib -> urllib PY3_BASE_MODULES.add('ipaddress')

jacalata added a commit that referenced this issue Jan 10, 2025
A fast following update with a packaging fix

fix ubuntu and max-x64 executables are missing a dependency #337
fix get: implement size parameters (--width and --height) #94
fix Filtering does not work for a full workbook (--fullpdf) #233
@jacalata
Copy link
Contributor Author

This was not fixed. Must be some difference in the repo settings I tested with.

@jacalata jacalata reopened this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant