Feature request: let users choose when dialog closes #3404
brmscheiner
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The
<Dialog>
component currently has the following behavior:It should be possible to choose whether
onClose
is called for outside clicks or escape key presses, since both may not be desired. The workaround is to do something likeonClose={() => {}}
and reimplement the escape key listener in the client app.Note that this behavior can be easily achieved with other component library APIs, eg. material.
Two new props like
closeOnPanelClick
andcloseOnEscape
(both defaulting to true) would do the trick.Beta Was this translation helpful? Give feedback.
All reactions