Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade test suite #71

Open
1 of 2 tasks
Th3Mouk opened this issue Aug 8, 2018 · 3 comments
Open
1 of 2 tasks

Upgrade test suite #71

Th3Mouk opened this issue Aug 8, 2018 · 3 comments
Labels
bug Something isn't working
Milestone
Version 2.1

Comments

@Th3Mouk
Copy link
Collaborator

Th3Mouk commented Aug 8, 2018 •
edited by tbolier
Loading

Issue summary

Currently tests don't passed in PHP 7.2 for RowTests.php. PHP 7.3 is now in beta so we must include it too.

If Scrutinizer don't provide the feature, we might consider taking the tests under Travis CI.

Issue checklist

  • Add PHP 7.2 tests
  • Add PHP 7.3 tests
@Th3Mouk Th3Mouk added the bug Something isn't working label Aug 8, 2018
@Th3Mouk Th3Mouk added this to the Version 2.0 milestone Aug 8, 2018
@tbolier
Copy link
Owner

tbolier commented Aug 20, 2018

I will look into this in the coming days.

Thanks for reporting!

@tbolier tbolier modified the milestones: Version 2.0, Version 2.1 Sep 8, 2018
@tbolier
Copy link
Owner

tbolier commented Sep 8, 2018 •
edited
Loading

I have assigned this issue to milestone 2.1

However 7.2 will be supported ASAP

@tbolier
Copy link
Owner

tbolier commented Sep 8, 2018

I have test 7.2.9 and it worked fine without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 2.1
Development

No branches or pull requests
2 participants
@Th3Mouk @tbolier