Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto/improve code quality #11

Open
tchapacan opened this issue Mar 30, 2024 · 0 comments
Open

Refacto/improve code quality #11

tchapacan opened this issue Mar 30, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tchapacan
Copy link
Owner

The code has been pushed in early stage and i'm a beginner in rust, so I'm sure there is a plenty of room for improvement.

I didn't want to overengineer the codebase for such a simple usecase, but some part can be improve and discuss:

Seek if we can use leverage a proper datastructure / type and iterate through it to pass parameter while using the querying method?

  • In client.rs separate the logic of building the different type of query (post, post_authenticated, login, logout) and the actual query to retrieve metrics (get_wan_config, get_status, get_devices, etc..), some how like a service <==> adapter "pattern"

  • If you are confident enough in rust, dig deeper in the structure of the project (module, trait, "class") etc

@tchapacan tchapacan added enhancement New feature or request help wanted Extra attention is needed labels Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant