Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set package license #276

Closed
Sami32 opened this issue Aug 29, 2018 · 18 comments
Closed

How to set package license #276

Sami32 opened this issue Aug 29, 2018 · 18 comments

Comments

@Sami32
Copy link

Sami32 commented Aug 29, 2018

Argh i didn't saw any way to set a license. Unbuntu 18.04 throw that it is proprietary license because none has been added.
License: or <license>GPLv2</license>

Is there is a way to set the package license? I really hope that i have missed it.

@tcurdt
Copy link
Owner

tcurdt commented Aug 30, 2018

There is no such field in the control file but I think you are talking about debian/copyright file

Also see https://www.debian.org/doc/manuals/maint-guide/dreq.en.html

@tcurdt tcurdt changed the title License??? How to set package license Aug 30, 2018
@tmortagne
Copy link
Collaborator

There is no such field in the control file

Made me realize I made the exact same mistake. The funny thing is that in Ubuntu I cannot find a single package in /var/cache/apt/archive which provide the license (was searching for examples).

@Sami32
Copy link
Author

Sami32 commented Aug 30, 2018

Thank for you answer +1
I've only realized that later. I was also searching for example ;)

It should be a nice enhancement to add this feature in jdeb 2.0 ;)

@tcurdt
Copy link
Owner

tcurdt commented Aug 30, 2018

It should be a nice enhancement to add this feature in jdeb 2.0 ;)

How would you imagine that feature to be working?

@Sami32
Copy link
Author

Sami32 commented Aug 30, 2018

I was thinking of adding it in your Maven example, like:

<data>
	<src>${project.external-resources}/linux/debian/changelog.gz</src>
	<dst>/usr/share/doc/${project.name.camel}/changelog.gz</dst>
	<type>file</type>
</data>
<data>
	<src>${project.external-resources}/linux/debian/copyright</src>
	<dst>/usr/share/doc/${project.name.camel}/copyright</dst>
	<type>file</type>
</data>

And add 2 generic template files into your code, like below for the copyright file:

Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Digital Media Server
Upstream-Contact: Nadahar <nadahar@digitalmediaserver.org>
Source: https://github.com/DigitalMediaServer/DigitalMediaServer/releases

Files: *
Copyright: Copyleft (©) 2016-2018 Digital Media Server.
Licence: GPL-3.0

  This program is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 3 of the License, or any
  later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  You should have received a copy of the GNU General Public License with
  the Debian GNU/Linux distribution in file /usr/share/common-licenses/GPL;
  if not, write to the Free Software Foundation, Inc., 59 Temple Place,
  Suite 330, Boston, MA  02111-1307  USA

                    GNU GENERAL PUBLIC LICENSE
                       Version 3, 29 June 2007
...

I'm sure that it came like an evidence to you but when we are not from Linux world it doesn't ;)

@tmortagne
Copy link
Collaborator

tmortagne commented Aug 30, 2018

Since the Maven pom contains a <licenses> information (if you provide it) it would make sense to generate a copyright files which contains it by default (associated to File: *).

@Sami32
Copy link
Author

Sami32 commented Aug 31, 2018

Adding the copyright file didn't make it, as PackageKit show:

Package description
  package:     dms-0.3.0-SNAPSHOT.all
  summary:     Media server
  license:     unknown
  group:       programming
  description: Media server
  size:        55926352 bytes
  url:         http://www.digitalmediaserver.com/

@tcurdt
Copy link
Owner

tcurdt commented Aug 31, 2018

I am all for adding this to the example - but I suggest to find a reference package to compare against.

@Sami32
Copy link
Author

Sami32 commented Aug 31, 2018

Do you have any reference package in mind?

@tcurdt
Copy link
Owner

tcurdt commented Aug 31, 2018

@Sami32 Just like @tmortagne I would have expected the latest Ubuntu packages to have this. Maybe check an official Debian packages.

@Sami32
Copy link
Author

Sami32 commented Sep 1, 2018

It seem that my configuration was fine, but that it is an issue from Ubuntu Software manager:
https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/435183
microsoft/vscode#3321

@tcurdt
Copy link
Owner

tcurdt commented Sep 1, 2018

Does lintian check this?

@Sami32
Copy link
Author

Sami32 commented Sep 1, 2018

Sorry i've no idea as i've never used it not knowing it.

@Sami32 Sami32 closed this as completed Sep 1, 2018
@Sami32
Copy link
Author

Sami32 commented Sep 2, 2018

@tcurdt Thank you for making me discover that tool 👍
lintian is great, perhaps a little too much when i see all these errors and warning;)

It seem that the changelog and copyright files are not set in the correct place inside the package

E: dms: changelog-file-missing-in-native-package
E: dms: no-copyright-file
E: dms: extended-description-is-empty

But there are in as they are been found in the /usr/share/docs folders after install.
So yest it seem that the plugin doesn't work as expected, but it will not doesn't change that Ubuntu Software manager have its own issue.

@Sami32
Copy link
Author

Sami32 commented Sep 2, 2018

@tcurdt That said when i read that:

E: dms: systemd-service-file-outside-lib usr/lib/systemd/system/dms.service

EDIT:
It seem that all the systemd specifications are not the same for all the Linux distributions.
I will really have loved if they could get some standardisation between them!

@Sami32
Copy link
Author

Sami32 commented Sep 3, 2018

Ah ok, i get these Lintian errors because the project name and folder was not the same.

@tmortagne
Copy link
Collaborator

Since the Maven pom contains a information (if you provide it) it would make sense to generate a copyright files which contains it by default (associated to File: *).

That's actually #106 I think :)

@Sami32
Copy link
Author

Sami32 commented Sep 6, 2018

Hehe, yes ;)
I just forgot the extra dot that i had set in the name, i become senile i guess ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants