From 9cc66927b6da66e439ae35faad0f05a9756a820c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Filip=20V=C3=A1gner?= <fvagner@redhat.com>
Date: Thu, 9 Jan 2025 16:19:02 +0100
Subject: [PATCH] Fix `tmt test import` error when restraint metadata
 attributes are empty (#3451)

---
 .../import/data/parent/empty-dependencies/metadata  | 13 +++++++++++++
 .../data/parent/empty-dependencies/runtest.sh       |  3 +++
 tests/test/import/test.sh                           | 10 ++++++++++
 tmt/convert.py                                      |  4 ++--
 4 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 tests/test/import/data/parent/empty-dependencies/metadata
 create mode 100755 tests/test/import/data/parent/empty-dependencies/runtest.sh

diff --git a/tests/test/import/data/parent/empty-dependencies/metadata b/tests/test/import/data/parent/empty-dependencies/metadata
new file mode 100644
index 0000000000..7cffc52a23
--- /dev/null
+++ b/tests/test/import/data/parent/empty-dependencies/metadata
@@ -0,0 +1,13 @@
+[General]
+name=/empty_dependencies
+owner=Nobody <nobody@localhost.localdomain>
+description=Empty dependencies
+license=MIT
+confidential=no
+destructive=no
+
+[restraint]
+entry_point=bash -x ./runtest.sh
+dependencies=
+softDependencies=
+max_time=5m
diff --git a/tests/test/import/data/parent/empty-dependencies/runtest.sh b/tests/test/import/data/parent/empty-dependencies/runtest.sh
new file mode 100755
index 0000000000..4eeb71ccd7
--- /dev/null
+++ b/tests/test/import/data/parent/empty-dependencies/runtest.sh
@@ -0,0 +1,3 @@
+#!/bin/bash
+
+echo "A simple test"
diff --git a/tests/test/import/test.sh b/tests/test/import/test.sh
index 51261d9e2d..f041920c69 100755
--- a/tests/test/import/test.sh
+++ b/tests/test/import/test.sh
@@ -146,6 +146,16 @@ rlJournalStart
         rlRun 'popd'
     rlPhaseEnd
 
+    rlPhaseStartTest "Empty dependencies (Restraint)"
+        rlRun 'pushd $tmp/data/parent/empty-dependencies'
+        rlRun -s 'tmt test import --restraint --no-nitrate --no-purpose' '0'
+        rlAssertExists "main.fmf"
+        rlRun 'cat main.fmf'
+        rlAssertGrep 'require:\s*\[\]' "main.fmf"
+        rlAssertGrep 'recommend:\s*\[\]' "main.fmf"
+        rlRun 'popd'
+    rlPhaseEnd
+
     rlPhaseStartTest "Target run having a single line"
         rlRun 'pushd $tmp/data/parent/single-line-run'
         rlRun -s 'tmt test import --makefile --no-nitrate --no-purpose' '0'
diff --git a/tmt/convert.py b/tmt/convert.py
index fc8eeff66c..b7f9253ed5 100644
--- a/tmt/convert.py
+++ b/tmt/convert.py
@@ -336,7 +336,7 @@ def sanitize_name(name: str) -> str:
     if requires:
         data['require'] = [
             sanitize_name(require.strip()) for line in requires
-            for require in line.split(rec_separator)]
+            for require in line.split(rec_separator) if require.strip()]
         echo(style('require: ', fg='green') + ' '.join(data['require']))
 
     # Requires or softDependencies (optional) goes to recommend
@@ -344,7 +344,7 @@ def sanitize_name(name: str) -> str:
     if recommends:
         data['recommend'] = [
             sanitize_name(recommend.strip()) for line in recommends
-            for recommend in line.split(rec_separator)]
+            for recommend in line.split(rec_separator) if recommend.strip()]
         echo(
             style('recommend: ', fg='green') + ' '.join(data['recommend']))