New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when using withLatestFrom with nonsynced streams #4

Open

apaatsio opened this issue Sep 21, 2018 · 0 comments

apaatsio commented Sep 21, 2018

flutter_bloc_tutorial/lib/bloc.dart

Lines 20 to 24 in 7c1cea3

    
           _results = _query.distinct().asyncMap(api.get).asBroadcastStream(); 
        
           _log = Observable(results) 
        
               .withLatestFrom(_query.stream, (_, query) => 'Results for $query') 
        
               .asBroadcastStream();

I didn't try to run the code but I think there's a bug here when two queries are made in quick succession.

Consider the following time line:

query for "dog"
call api.get("dog")
query for "cat"
call api.get("cat")
receive API response for "dog"
log "Results for cat" (because "cat" is the latest value in _query stream)
receive API response for "cat"
log "Results for cat"

That is, it logs "Results for cat" twice and never logs "Results for dog" because _query and _results streams are not synced/zipped.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment