Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RandAugment magnitude standard deviation is either 0 or 1 #10980

Closed
Vandertic opened this issue Apr 15, 2023 · 5 comments
Closed

RandAugment magnitude standard deviation is either 0 or 1 #10980

Vandertic opened this issue Apr 15, 2023 · 5 comments
Assignees
@LakshmiKalaKadali
Labels
models:official models that come under official repository stale stat:awaiting response Waiting on input from the contributor type:bug Bug in the code

Comments

@Vandertic
Copy link

If I am not mistaken, there should be a level_std* after the +=, for otherwise the applied standard deviation is always 1.

models/official/vision/ops/augment.py

Line 1566 in 9fb4a4f

level += tf.random.normal([], dtype=tf.float32)

@laxmareddyp laxmareddyp assigned laxmareddyp and unassigned sineeli Apr 17, 2023
@laxmareddyp laxmareddyp added models:official models that come under official repository type:bug Bug in the code labels Apr 17, 2023
@laxmareddyp
Copy link
Collaborator

Hi @fyangf,

Could you please look into this issue in your free time.

Thanks.

@laxmareddyp laxmareddyp added the stat:awaiting model gardener Waiting on input from TensorFlow model gardener label Apr 28, 2023
@LakshmiKalaKadali
Copy link
Collaborator

Hi @Vandertic,

Observed the mentioned behavior and raised a PR #13509 by adding level_std* parameter to tf.random.normal([], dtype=tf.float32), that increases the randomness in the augmentation process. Please track the PR.

Thank You

@LakshmiKalaKadali LakshmiKalaKadali added stat:awaiting response Waiting on input from the contributor and removed stat:awaiting model gardener Waiting on input from TensorFlow model gardener labels Dec 23, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Dec 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

This issue was closed due to lack of activity after being marked stale for past 7 days.

@github-actions github-actions bot closed this as completed Jan 7, 2025
@google-ml-butler Google-ML-Butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LakshmiKalaKadali LakshmiKalaKadali

Labels
models:official models that come under official repository stale stat:awaiting response Waiting on input from the contributor type:bug Bug in the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Vandertic @fyangf @laxmareddyp @sineeli @LakshmiKalaKadali