From e64012e71a96edb6cb541ceb2d0cae36f1b10d26 Mon Sep 17 00:00:00 2001
From: joselegitan <joselegitan@protonmail.com>
Date: Wed, 29 Nov 2023 11:05:44 +0100
Subject: [PATCH] feat: update routeMap poi to have position + update poiDeck
 to be more generic

---
 components/PoisCard/PoiCardLight.vue      | 2 +-
 components/PoisCard/PoisDeck.vue          | 3 +--
 components/PoisDetails/Route/RouteMap.vue | 5 +++--
 lib/apiPoiDeps.ts                         | 4 +++-
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/components/PoisCard/PoiCardLight.vue b/components/PoisCard/PoiCardLight.vue
index cf8213016..02a645e90 100644
--- a/components/PoisCard/PoiCardLight.vue
+++ b/components/PoisCard/PoiCardLight.vue
@@ -15,7 +15,7 @@
             :picto="icon"
             size="lg"
             :image="undefined"
-            :text="position"
+            :text="poi.properties.position"
           />
           {{ name }}
         </h3>
diff --git a/components/PoisCard/PoisDeck.vue b/components/PoisCard/PoisDeck.vue
index ba5128efe..58658f350 100644
--- a/components/PoisCard/PoisDeck.vue
+++ b/components/PoisCard/PoisDeck.vue
@@ -2,10 +2,9 @@
   <div class="tw-flex tw-justify-between tw-flex-wrap tw-gap-6">
     <component
       :is="poisCard"
-      v-for="(item, index) in pois"
+      v-for="item in pois"
       :key="item.properties.metadata.id"
       :poi="item"
-      :position="(index + 1).toString()"
       :class="[
         'tw-grow-1 poi-deck',
         !isFavorite(item.properties.metadata.id) &&
diff --git a/components/PoisDetails/Route/RouteMap.vue b/components/PoisDetails/Route/RouteMap.vue
index 3ee4543b3..2db68e777 100644
--- a/components/PoisDetails/Route/RouteMap.vue
+++ b/components/PoisDetails/Route/RouteMap.vue
@@ -98,12 +98,13 @@ export default defineNuxtComponent({
   },
 
   created() {
-    this.routeCollection = this.route.features.map((feature) => {
+    this.routeCollection = this.route.features.map((feature, index) => {
       if (feature.properties['route:point:type']) {
         const mapPoi = apiRouteWaypointToApiPoi(
           feature as ApiRouteWaypoint,
           this.colorFill,
-          this.colorLine
+          this.colorLine,
+          (index + 1).toString()
         )
         this.points.push(mapPoi)
         return mapPoi
diff --git a/lib/apiPoiDeps.ts b/lib/apiPoiDeps.ts
index da9a0a5df..089b520dc 100644
--- a/lib/apiPoiDeps.ts
+++ b/lib/apiPoiDeps.ts
@@ -63,7 +63,8 @@ export const iconMap: { [key: string]: string } = {
 export function apiRouteWaypointToApiPoi(
   waypoint: ApiRouteWaypoint,
   colorFill: string,
-  colorLine: string
+  colorLine: string,
+  position?: string
 ): ApiPoi {
   return {
     ...waypoint,
@@ -79,6 +80,7 @@ export function apiRouteWaypointToApiPoi(
         color_fill: colorFill,
         color_line: colorLine,
       },
+      position,
       editorial: {
         popup_fields: [
           {