-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Password Autofill Provider shows on termux #3909
Comments
Autofill is managed by Android so apps can't decide if they must show or no, in Android there is no settings for disable autofill for apps. |
This is a workaround and not a solution. |
I cannot access my clipboard because of this bug. Hate switching to another keyboard when using termux and change back when not using it. |
This happens after updating to Android 14To offer smoother integration with password managers, the Credential Manager API was replaced the Autofill framework. This may not work as well with older apps that may not provide the context in the way that it expects. This is likely happening because the text field is direct-input. Since Termux has the autofill option in more options, and termux only uses one text input and can't definitively discern password input, this could cause the popup. Workarounds:
|
Since this was reported using bitwarden, I'd like to offer a solution to those with the same problem also using the bitwarden application. In the following Settings—>Autofill menu, at the very bottom there is an option to Block AutoFill. Selecting this will open a menu with a button labeled New blocked URI, selecting that will open a dialog where you can enter the following to prevent bitwarden from suggesting any auto-fill whenever using Termux. Screenshots from my device attached for visual reference. Hope this helps!
|
Now you can't autofill when you wanted to. |
We never wanted to. Please see the initial report and expected behavior. |
So what do you think about the option "autofill password" existed for? |
@psyburr That is a pretty good workaround. Do you know if that is possible on stock Android (with no password manager)? |
All right, I found a workaround. Go to Settings and "Passwords, passkeys and autofill". Select the preferred service, for me on Pixel 6a, it is Google. That will take you to "Use Autofill with Google". Disable that and it should be fixed. If you are actually using Google password manager you will have to find a different solution. |
@yubrajbhoi I've set it to Bitwarden since day one I bought my Pixel 6a. I don't know if switching it back to Google then again to Bitwarden will do anything... I'm using the "disable autofill for termux" workaround now. |
@escape0707 Yeah, it won't do anything. You have to disable the app you save set as preferred service. In my case I use |
…for usernames - The AutoFill type and hints are no longer hardcoded in `TerminalView` class and `TermuxActivity` layout xml. They are dynamically set to required values before making a manual AutoFill request and reverted back afterwards to default values. The hardcoded value `AUTOFILL_TYPE_TEXT` returned by `getAutofillType()` was causing the AutoFill UI to show on Activity starts, this will return `getAutofillType` by default now so that AutoFill UI isn't shown automatically. - The AutoFill importance is no longer hardcoded in `TermuxActivity` layout xml and is returned by `TerminalView` class itself by `getImportantForAutofill()`. - The AutoFill function in `TermuxActivity` for making a manual AutoFill request is moved to `TerminalView` class. This and moving of hardcoded values to `TerminalView` class mentioned above is done as complete logic of AutoFill should be handled by `TerminalView` class itself and not scattered in various places. - The Terminal context menu now supports AutoFilling a username. Note that GBoard/Google Password Manager seems to have a bug where it will still show `Pick a saved password` instead of username, even though `AUTOFILL_HINT_USERNAME` is being requested, however it will still AutoFill a username of selected entry correctly. - Pressing the back button to close the keyboard will also cancel the current manually requested AutoFill request and UI will not show when keyboard is opened again. Closes #3909
…for usernames - The AutoFill type and hints are no longer hardcoded in `TerminalView` class and `TermuxActivity` layout xml. They are dynamically set to required values before making a manual AutoFill request and reverted back afterwards to default values. The hardcoded value `AUTOFILL_TYPE_TEXT` returned by `getAutofillType()` was causing the AutoFill UI to show on Activity starts, this will return `AUTOFILL_TYPE_NONE` by default now so that AutoFill UI isn't shown automatically. - The AutoFill importance is no longer hardcoded in `TermuxActivity` layout xml and is returned by `TerminalView` class itself by `getImportantForAutofill()`. - The AutoFill function in `TermuxActivity` for making a manual AutoFill request is moved to `TerminalView` class. This and moving of hardcoded values to `TerminalView` class mentioned above is done as complete logic of AutoFill should be handled by `TerminalView` class itself and not scattered in various places. - The Terminal context menu now supports AutoFilling a username. Note that GBoard/Google Password Manager seems to have a bug where it will still show `Pick a saved password` instead of username, even though `AUTOFILL_HINT_USERNAME` is being requested, however it will still AutoFill a username of selected entry correctly. - Pressing the back button to close the keyboard will also cancel the current manually requested AutoFill request and UI will not show when keyboard is opened again. Closes #3909
Check #4125. Users using GitHub action builds should test and report so that it can be merged. |
Thanks. In the last build action the annoying password button no longer appears above the keyboard. I hope the fix will come to the latest stable and beta version soon. |
Welcome. Should be available in next beta at least. |
In that case the base branch of the pr should be 119.beta. right? |
Master branch is where everything gets pushed for final release, beta branches pick and patch commits from master branch before release. |
Why its opposite? Commits should be merge on beta branch first to test all are working with other commits which isn't pushed to master. |
All the development is done on master branch, anything I push there is thoroughly tested, beta in the termux app's context means that features are not final and not ready for release and may change, not that they are unstable. Beta branches were never used before, it was only used for last release with specific commits picked from master branch and certain features disabled with patch commits that were not ready for release. |
Oh.. then it's more like a feat branch. But I'm using 119 so can't install 118 on top of it. 😞 |
You can install github debuggable apks with |
Thanks for the info. |
…for usernames - The AutoFill type and hints are no longer hardcoded in `TerminalView` class and `TermuxActivity` layout xml. They are dynamically set to required values before making a manual AutoFill request and reverted back afterwards to default values. The hardcoded value `AUTOFILL_TYPE_TEXT` returned by `getAutofillType()` was causing the AutoFill UI to show on Activity starts, this will return `AUTOFILL_TYPE_NONE` by default now so that AutoFill UI isn't shown automatically. - The AutoFill importance is no longer hardcoded in `TermuxActivity` layout xml and is returned by `TerminalView` class itself by `getImportantForAutofill()`. - The AutoFill function in `TermuxActivity` for making a manual AutoFill request is moved to `TerminalView` class. This and moving of hardcoded values to `TerminalView` class mentioned above is done as complete logic of AutoFill should be handled by `TerminalView` class itself and not scattered in various places. - The Terminal context menu now supports AutoFilling a username. Note that GBoard/Google Password Manager seems to have a bug where it will still show `Pick a saved password` instead of username, even though `AUTOFILL_HINT_USERNAME` is being requested, however it will still AutoFill a username of selected entry correctly. - Pressing the back button to close the keyboard will also cancel the current manually requested AutoFill request and UI will not show when keyboard is opened again. Closes termux#3909
As I use 1Password, I cannot filter the apps in the password manager, and I did not have the option to exclude Termux. The "Open 1Password" popup was very annoying to me. I managed to find another workaround: with Tasker, I disable (deselect) the autofill service in the system settings when Termux is focused and enable it back once another app becomes active. The commands for ADB action in Tasker are: settings delete secure autofill_service settings put secure autofill_service com.onepassword.android/com.onepassword.android.autofill.services.AutofillService This works but requires Tasker to have access to ADB over TCP. I hope the fix for this issue is included in a release soon so I can ditch my workaround. |
Problem description
Password Autofill Service shows on termux terminal, which can disturb with the workflow.
Steps to reproduce the behavior.
What is the expected behavior?
No Autofill
System information
The text was updated successfully, but these errors were encountered: