Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptor SignatureType will always return 0 #182

Open
cyyber opened this issue Jul 22, 2022 · 0 comments
Open

Descriptor SignatureType will always return 0 #182

cyyber opened this issue Jul 22, 2022 · 0 comments

Comments

@cyyber
Copy link
Member

cyyber commented Jul 22, 2022

Descriptor signature type will always return 0 no matters, whatever the value of the signature type is.
https://github.com/theQRL/qrllib/blob/master/src/qrl/qrlDescriptor.h#L68

The code in that line should be following
auto signatureType = static_cast<eSignatureType>((bytes[0] >> 4) & 0x0F);

This issue is not critical as we are using XMSS which has signature type 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant