Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more symmetric command parsing for sfwriter and sfreader functions #49

Open
grumpyinca opened this issue Jun 25, 2018 · 2 comments

Comments

@grumpyinca
Copy link
Collaborator

File name should be passed in argument list.

@grumpyinca grumpyinca added this to the 0.5 milestone Jun 25, 2018
@1fifoto 1fifoto self-assigned this Jun 27, 2018
@1fifoto 1fifoto removed this from the 0.5 milestone Jun 28, 2018
@1fifoto 1fifoto removed their assignment Jun 28, 2018
@grumpyinca
Copy link
Collaborator Author

The conversation that prompted me to open this issue assumed that these functions differed in their calling arguments. I just looked at the code. See below. Is it possible that the code got enhanced or is it possible that the issue never really existed in the first place ?

Save.js:
function sfwriter(cpname) {

start.js:
function sfreader(sfname) {

@1fifoto 1fifoto added this to the pcyl-web milestone Jul 4, 2018
@1fifoto
Copy link
Contributor

1fifoto commented Jul 4, 2018

The structure of sfwriter and sfreader are different. One does command parsing, but the other doesn't. They should be made similar in this aspect.

@grumpyinca grumpyinca changed the title Provide more symmetric calling for sfwriter and sfreader functions Provide more symmetric command parsing for sfwriter and sfreader functions Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants