Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system has issues with non-interactive use #7

Open
blm768 opened this issue Oct 24, 2017 · 3 comments
Open

Build system has issues with non-interactive use #7

blm768 opened this issue Oct 24, 2017 · 3 comments

Comments

@blm768
Copy link

blm768 commented Oct 24, 2017

I've been looking into using OpenPLC as part of a student project. I was planning to build a Debian package and/or a Docker image for easy deployment, but I've found that the build system isn't very well suited to non-interactive use because it prompts interactively for a number of configuration options. I've made some modifications in my own fork that allow passing the necessary values non-interactively, but I'm curious as to whether you'd be interested in merging those changes into the main project and/or looking into other ways to make the build system more robust and distribution-agnostic.

@thiagoralves
Copy link
Owner

Your changes seems nice, I don't think it is a problem to incorporate them. The only issue is your last commit, where you removed the lines to install Libmodbus. This will break support for Modbus external devices.

@blm768
Copy link
Author

blm768 commented Oct 25, 2017

Yeah, I'll have to figure out how to handle that. The main issue is that to build a typical Debian package, the build scripts generally can't (or at least shouldn't) rely on sudo to install files to the host that's building the package. I'll have to think about how to handle that properly; the easiest way is probably to link libmodbus statically.

@st31ny
Copy link

st31ny commented May 18, 2018

There is actually a Debian package for libmodbus (https://packages.debian.org/stretch/libmodbus-dev), so libmodbus should definitely not be included in the Debian package.

I'd propose using a Makefile with different targets for different build steps, such as make install-dep to install dependencies. That way you could configure your build very flexibly and easily include it in the debian packaging toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants