From 33c23e789e577bd6463e135cec4e25cfcfc9964a Mon Sep 17 00:00:00 2001 From: gregfromstl Date: Wed, 4 Dec 2024 20:36:42 +0000 Subject: [PATCH] [SDK] Fix: Remove auth from useConnectModal props as it's not currently supported (#5618) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #5615 --- ## PR-Codex overview This PR focuses on removing the `auth` property from the `useConnectModal` options in the `thirdweb` package, as it is currently unsupported. ### Detailed summary - Removed the `auth` property from `UseConnectModalOptions` in `packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx`. - Updated documentation to reflect the removal of the `auth` prop. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- .changeset/tidy-zoos-know.md | 5 +++++ .../src/react/web/ui/ConnectWallet/useConnectModal.tsx | 9 --------- 2 files changed, 5 insertions(+), 9 deletions(-) create mode 100644 .changeset/tidy-zoos-know.md diff --git a/.changeset/tidy-zoos-know.md b/.changeset/tidy-zoos-know.md new file mode 100644 index 00000000000..ff07dc33506 --- /dev/null +++ b/.changeset/tidy-zoos-know.md @@ -0,0 +1,5 @@ +--- +"thirdweb": patch +--- + +Fix: Removed the auth prop from useConnectModal as it is currently not supported diff --git a/packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx b/packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx index 3563f93595c..2bcb1376c2f 100644 --- a/packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx +++ b/packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx @@ -5,7 +5,6 @@ import type { Wallet } from "../../../../wallets/interfaces/wallet.js"; import type { SmartWalletOptions } from "../../../../wallets/smart/types.js"; import type { AppMetadata } from "../../../../wallets/types.js"; import type { Theme } from "../../../core/design-system/index.js"; -import type { SiweAuthOptions } from "../../../core/hooks/auth/useSiweAuth.js"; import { SetRootElementContext } from "../../../core/providers/RootElementContext.js"; import { WalletUIStatesProvider } from "../../providers/wallet-ui-states-provider.js"; import { canFitWideModal } from "../../utils/canFitWideModal.js"; @@ -433,14 +432,6 @@ export type UseConnectModalOptions = { * If you want to hide the branding, set this prop to `false` */ showThirdwebBranding?: boolean; - - /** - * Enable SIWE (Sign in with Ethererum) by passing an object of type `SiweAuthOptions` to - * enforce the users to sign a message after connecting their wallet to authenticate themselves. - * - * Refer to the [`SiweAuthOptions`](https://portal.thirdweb.com/references/typescript/v5/SiweAuthOptions) for more details - */ - auth?: SiweAuthOptions; }; // TODO: consilidate Button/Embed/Modal props into one type with extras