From a9a3f0f423c1ec78c2cc72507f21c5b3ca0d1dbd Mon Sep 17 00:00:00 2001 From: gregfromstl <17715009+gregfromstl@users.noreply.github.com> Date: Mon, 22 Jul 2024 17:34:29 +0000 Subject: [PATCH] fix(deploy): add missing version argument in computeDeploymentInfoFromContractId function (#3769) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix deterministic deploys with specified versions by adding the 'version' argument to the 'computeDeploymentInfoFromContractId' function. --- --- ## PR-Codex overview This PR focuses on fixing deterministic deploys with specified versions in the `compute-published-contract-deploy-info.ts` file under `thirdweb` package. ### Detailed summary - Added `version` field to `computePublishedContractDeployInfo` function parameters. - Utilizes the specified version for deterministic deployments. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- .changeset/large-cycles-joke.md | 5 +++++ .../utils/any-evm/compute-published-contract-deploy-info.ts | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/large-cycles-joke.md diff --git a/.changeset/large-cycles-joke.md b/.changeset/large-cycles-joke.md new file mode 100644 index 00000000000..adaaff6350e --- /dev/null +++ b/.changeset/large-cycles-joke.md @@ -0,0 +1,5 @@ +--- +"thirdweb": patch +--- + +Fix deterministic deploys with specified versions diff --git a/packages/thirdweb/src/utils/any-evm/compute-published-contract-deploy-info.ts b/packages/thirdweb/src/utils/any-evm/compute-published-contract-deploy-info.ts index 14777c68860..5ed818c8536 100644 --- a/packages/thirdweb/src/utils/any-evm/compute-published-contract-deploy-info.ts +++ b/packages/thirdweb/src/utils/any-evm/compute-published-contract-deploy-info.ts @@ -24,6 +24,7 @@ export async function computeDeploymentInfoFromContractId(args: { client, contractId, publisher: args.publisher, + version: args.version, }); return computeDeploymentInfoFromMetadata({ client,