From 9ab98e26c9f09da3e1e8c77e9ef4268126bb0660 Mon Sep 17 00:00:00 2001 From: hansemannn Date: Mon, 31 Aug 2015 14:51:53 -0700 Subject: [PATCH 1/3] [MOD-2131] Fix dragging issues --- ios/Classes/TiMapView.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ios/Classes/TiMapView.m b/ios/Classes/TiMapView.m index 1b141658..96fd230f 100644 --- a/ios/Classes/TiMapView.m +++ b/ios/Classes/TiMapView.m @@ -823,11 +823,11 @@ - (void)mapViewDidFailLoadingMap:(MKMapView *)mapView withError:(NSError *)error - (void)mapView:(MKMapView *)mapView annotationView:(MKAnnotationView *)annotationView didChangeDragState:(MKAnnotationViewDragState)newState fromOldState:(MKAnnotationViewDragState)oldState { [self firePinChangeDragState:annotationView newState:newState fromOldState:oldState]; - if (newState == MKAnnotationViewDragStateStarting) { + if (oldState == MKAnnotationViewDragStateStarting) { [annotationView setDragState: MKAnnotationViewDragStateDragging]; - } else if (newState == MKAnnotationViewDragStateEnding || newState == MKAnnotationViewDragStateCanceling) { + } else if (oldState == MKAnnotationViewDragStateEnding || newState == MKAnnotationViewDragStateCanceling) { [annotationView setDragState: MKAnnotationViewDragStateNone]; - } + } } - (void)firePinChangeDragState:(MKAnnotationView *) pinview newState:(MKAnnotationViewDragState)newState fromOldState:(MKAnnotationViewDragState)oldState From ef76fbbd438ab703c225f6bfd56a0abc2be87da4 Mon Sep 17 00:00:00 2001 From: hansemannn Date: Mon, 31 Aug 2015 15:16:57 -0700 Subject: [PATCH 2/3] [MOD-2131] Update the docs to show all drag states --- apidoc/View.yml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/apidoc/View.yml b/apidoc/View.yml index 52a7af88..9f07e56d 100644 --- a/apidoc/View.yml +++ b/apidoc/View.yml @@ -310,8 +310,21 @@ events: - name: newState summary: | New drag state for the annotation, one of - [ANNOTATION_DRAG_STATE_START](Modules.Map.ANNOTATION_DRAG_STATE_START), - [ANNOTATION_DRAG_STATE_END](Modules.Map.ANNOTATION_DRAG_STATE_END). + [ANNOTATION_DRAG_STATE_NONE](Titanium.Map.ANNOTATION_DRAG_STATE_NONE), + [ANNOTATION_DRAG_STATE_START](Titanium.Map.ANNOTATION_DRAG_STATE_START), + [ANNOTATION_DRAG_STATE_DRAG](Titanium.Map.ANNOTATION_DRAG_STATE_DRAG), + [ANNOTATION_DRAG_STATE_CANCEL](Titanium.Map.ANNOTATION_DRAG_STATE_CANCEL) or + [ANNOTATION_DRAG_STATE_END](Titanium.Map.ANNOTATION_DRAG_STATE_END). + type: Number + + - name: oldState + summary: | + Previous drag state for the annotation, one of + [ANNOTATION_DRAG_STATE_NONE](Titanium.Map.ANNOTATION_DRAG_STATE_NONE), + [ANNOTATION_DRAG_STATE_START](Titanium.Map.ANNOTATION_DRAG_STATE_START), + [ANNOTATION_DRAG_STATE_DRAG](Titanium.Map.ANNOTATION_DRAG_STATE_DRAG), + [ANNOTATION_DRAG_STATE_CANCEL](Titanium.Map.ANNOTATION_DRAG_STATE_CANCEL) or + [ANNOTATION_DRAG_STATE_END](Titanium.Map.ANNOTATION_DRAG_STATE_END). type: Number since: "3.1.0" From 1ece276779e266e753ef1312047cb163fc8d70cd Mon Sep 17 00:00:00 2001 From: hansemannn Date: Mon, 31 Aug 2015 15:17:23 -0700 Subject: [PATCH 3/3] [MOD-2131] Bumped new version 2.4.1 --- ios/documentation/changelog.md | 1 + ios/manifest | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ios/documentation/changelog.md b/ios/documentation/changelog.md index 6f22f649..395974b7 100644 --- a/ios/documentation/changelog.md +++ b/ios/documentation/changelog.md @@ -1,5 +1,6 @@ # Change Log
+v2.4.1  Fixed an issue where pins have not been draggable anymore. [MOD-2131]
 v2.4.0  iOS9: Upgrade map module to support bitcode. [TIMOB-19385]
 v2.3.2  Fixed map crash with polygons when not setting mapType. [TIMOB-19102]
 v2.3.1  Add drawing support. Includes polygons, polylines, and circles. [TIMOB-15410]
diff --git a/ios/manifest b/ios/manifest
index e1b80237..c4f207cc 100644
--- a/ios/manifest
+++ b/ios/manifest
@@ -2,7 +2,7 @@
 # this is your module manifest and used by Titanium
 # during compilation, packaging, distribution, etc.
 #
-version: 2.4.0
+version: 2.4.1
 apiversion: 2
 architectures: armv7 arm64 i386 x86_64
 description: External version of Map module