Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist #46

Closed
Tbaut opened this issue Aug 22, 2024 · 3 comments
Closed

Wishlist #46

Tbaut opened this issue Aug 22, 2024 · 3 comments

Comments

@Tbaut
Copy link

Tbaut commented Aug 22, 2024

Hey Tien after integrating dotconnect in a hackaton project, here's a list of things I'd love to have

  • I'd like to be able to totally control the opening and closing of the modal. For this, we have the isOpen but there's no onClose callback. I'm not sure if this is possible with web components.

  • Another somewhat specific need I'd have in our app: I'd like to be able to select a specific account in a 2nd step, after having selected an extension. This way, if users have shared several accounts, they can select the one they want the interface to take into account. This would probably mean we'd need a selectedAccount in the fields of useAccounts. This may be a too specific ask though.

In any case, thank you for this, it's been very helpful

@tien
Copy link
Owner

tien commented Aug 23, 2024

Thanks for the feedback @Tbaut

  • The missing onClose callback is an oversight on my part, will get this resolved ASAP.
  • For the selectedAccount feature, I have thought about including that before, but came to the conclusion that user most of the time would be better off creating their own account selection logic. Because there are so many different possibles' implementation (i.e single selection, multi-selection, different selection per page, etc). A bare-boned off the shelf solution might still prove useful, though, so I'll rethink this.

@Tbaut
Copy link
Author

Tbaut commented Aug 23, 2024

Thanks a lot.
I understand that it's not for every Dapp.

@tien
Copy link
Owner

tien commented Sep 2, 2024

@tien tien closed this as completed Sep 2, 2024
@tien tien closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants