Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scaling minimums and limits for deployment #541

Closed
jonespm opened this issue Oct 2, 2024 · 2 comments · Fixed by #565 or #571
Closed

Update scaling minimums and limits for deployment #541

jonespm opened this issue Oct 2, 2024 · 2 comments · Fixed by #565 or #571
Assignees
Labels
deployment Involves changes to deployment artifacts under service Effort: 4 Effort estimated at half-day

Comments

@jonespm
Copy link
Member

jonespm commented Oct 2, 2024

After #524 (and possibly #525) are completed, there are some other scaling changes made manually that need to be applied to the service scripts.

  • Set minReplicas to 2 on the autoscaler.
  • Change the maxReplicas to 4 to just match prod since we idle. Can remove the overlay for prod.
  • Configure resource limits on all deployments to match the medium limits
resources:
	limits:
	  cpu: '1'
	  memory: '4Gi'
	requests:
	  cpu: '100m'
	  memory: '800Mi'
@jonespm jonespm added the deployment Involves changes to deployment artifacts under service label Oct 2, 2024
@jonespm jonespm added the Effort: 4 Effort estimated at half-day label Oct 22, 2024
jonespm added a commit to jonespm/remote-office-hours-queue that referenced this issue Oct 28, 2024
jonespm added a commit to jonespm/remote-office-hours-queue that referenced this issue Oct 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to QA - Dev in ROHQ 1.11.0 Oct 28, 2024
@jonespm jonespm reopened this Oct 31, 2024
jonespm added a commit to jonespm/remote-office-hours-queue that referenced this issue Oct 31, 2024
@jonespm jonespm linked a pull request Oct 31, 2024 that will close this issue
@jonespm
Copy link
Member Author

jonespm commented Oct 31, 2024

Got this error trying to run this. Looks like resoruces were in the wrong place in the DeploymentConfig. Put up #571 to fix.

error: error validating "STDIN": error validating data: ValidationError(DeploymentConfig.spec): unknown field "resources" in com.github.openshift.api.apps.v1.DeploymentConfigSpec; if you choose to ignore these errors, turn validation off with --validate=false

@github-project-automation github-project-automation bot moved this from In Progress to QA - Dev in ROHQ 1.11.0 Oct 31, 2024
@jonespm
Copy link
Member Author

jonespm commented Oct 31, 2024

Ran these and verified that the settings are updated

@jonespm jonespm moved this from QA - Dev to Done in ROHQ 1.11.0 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Involves changes to deployment artifacts under service Effort: 4 Effort estimated at half-day
Projects
No open projects
Status: Done
1 participant