You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This project is awesome!
I'm looking for something that can validate that specific fields have specific tests (every model in a folder must have a not_null test on their load_date_time column).
A proposed implementation might be a prefix: +required_tests: {"testname!not_null.*load_date_time": 1}
This would require returning an object array rather than string array from tests_per_model ([{name: not_null_tablename_load_date_time, type: not_null}, ...], and adding a case statement to get_regex_match_count to split off and truncate the testname! - but would allow far more flexibility in future.
I'm happy to contribute with my mediocre python skills if you like the implementation.
The text was updated successfully, but these errors were encountered:
@ciejer Sorry for the long delay, life has been busy!
Yes I really like this idea! I think we'll need to implement another category of meta assertion though: +required_columns, to first check if the column is present, and then I'm thinking take some intersection of those requirements to assert that a column is present AND has the specified tests.
I can look into this in early Feb and get back to you with my thought on implementation, unless you've already forked and got something working :) In which case, I am happy to accept contributions!
Thanks for the reply @tnightengale! - I've been swamped myself, so no worries about the delay.
I'll be moving on from my current team shortly, but will be leaving a note on our ticket to check here when they get to revisiting our test coverage.
This project is awesome!
I'm looking for something that can validate that specific fields have specific tests (every model in a folder must have a not_null test on their load_date_time column).
A proposed implementation might be a prefix:
+required_tests: {"testname!not_null.*load_date_time": 1}
This would require returning an object array rather than string array from tests_per_model (
[{name: not_null_tablename_load_date_time, type: not_null}, ...]
, and adding a case statement to get_regex_match_count to split off and truncate thetestname!
- but would allow far more flexibility in future.I'm happy to contribute with my mediocre python skills if you like the implementation.
The text was updated successfully, but these errors were encountered: