Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing a token from an inactive set doesn't result in a broken link in the plugin #3186

Closed
rbosker opened this issue Oct 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rbosker
Copy link
Collaborator

rbosker commented Oct 22, 2024

Describe the bug
Referencing a token from an inactive set doesn't result in a broken link in the plugin

To Reproduce
Steps to reproduce the behavior:

  1. Have a light and dark set with a color token.
  2. In a new set, reference the created colors from light and dark
  3. Make dark or light active and see that the color in the new set is still there (while it should show a broken link).

Expected behavior
If a set is not active and reference a token from that set, you expect the link to that token to be broken.

Note
This worked before the 2.1.0 release properly, but probably this fix introduced the issue.
Related issue: #3179

@six7
Copy link
Collaborator

six7 commented Oct 24, 2024

yeah this was changed recently on purpose - inactive sets are now considered even if they are disabled, but are ranked last. this was made so that less users run into that problem of broken references when in fact the set was just not enabled

@six7 six7 closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants