Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables Don't Remap Once a Theme is Enabled in another Theme-group #3216

Open
keeganedwin opened this issue Dec 2, 2024 · 0 comments
Open
Labels
bug Something isn't working Figma variables needs-responder themes pro feature for theme groups and themes

Comments

@keeganedwin
Copy link
Collaborator

Describe the bug
I export variables with a base and mode theme-groups. If I then want to change the location of the light theme from mode to the base theme-group, I enable the light theme in base and disable it in mode/light. I then delete the mode collection from Figma and re-export the base theme-group with the light theme. I click apply to selection and the plugin remaps the variable. However, with a little more complicated setup, multiple theme-groups and themes selected seems to affect this and so does not remap the variable(s) correctly.

To Reproduce
Steps to reproduce the behavior:
Provided in the test file

Expected behavior
In this case, the tokens haven't changed. So regardless of which theme-group the theme is enabled, the plugin should just be able to remap it.

Screenshots or Screencasts
This recording shows a simple and working example
https://github.com/user-attachments/assets/3926a9b1-da59-4470-a71a-67a113269d4

Figma file (optional)
Test file

@rbosker rbosker added bug Something isn't working Figma variables themes pro feature for theme groups and themes needs-responder labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Figma variables needs-responder themes pro feature for theme groups and themes
Projects
Status: 📥 Triage
Development

No branches or pull requests

2 participants