Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VSCodium #787

Closed
j-lakeman opened this issue May 4, 2024 · 9 comments · Fixed by #788
Closed

Support VSCodium #787

j-lakeman opened this issue May 4, 2024 · 9 comments · Fixed by #788
Labels
C-feature request New feature request

Comments

@j-lakeman
Copy link

I want to suggest some general feature

Topgrade should…

… also consider VSCodium when upgrading VS Code extensions.

More information

binary would be codium additionally to code. Aliasing should do if possible.

@j-lakeman j-lakeman added the C-feature request New feature request label May 4, 2024
@SteveLauC
Copy link
Member

Yeah, this should be done, let me give it a fix

@SteveLauC SteveLauC mentioned this issue May 6, 2024
10 tasks
@SteveLauC
Copy link
Member

In #788, I added the support for:

  • binary lookup support, so Topgrade will recognize VSCodium and update its extensions
  • Alias support in configuration file, so that one can do
     [misc]
     disable = "vscodium"

But the alias support in command line is not added since it is currently not supported by the CLI parser used by Topgrade, related issue: clap-rs/clap#4416

@SteveLauC
Copy link
Member

Looks like there is some progress has been made to the linked issue: clap-rs/clap#5480

@j-lakeman
Copy link
Author

j-lakeman commented Nov 26, 2024

If anyone gets here in the meantime, my workaround is to symlink code to codium in ~/.local/bin. Topgrade picks that up then.

@Jisu-Woniu
Copy link

What about users using both VS Code and VSCodium at the same time?

@SteveLauC
Copy link
Member

In that case, we should not take the alias approach, instead, we should make VSCodium an individual Topgrade step.

@SteveLauC SteveLauC changed the title Alias "VSCodium" to "VS Code" Support VSCodium Jan 2, 2025
@SteveLauC
Copy link
Member

Gentle ping on @Jisu-Woniu and @j-lakeman, I implemented the support of VSCodium in #788, do you guys want to give it a test?

@j-lakeman
Copy link
Author

Just compiled it and it works for me! Awesome!

@SteveLauC
Copy link
Member

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants