You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we just spit out some warning messages if the IMAGE_LOAD_CONFIG_DIRECTORY doesn't exist or is too short to perform some checks, but it'd be nice to include that in the JSON output as well.
The text was updated successfully, but these errors were encountered:
Can you provide an example binary that would trigger these IMAGE_LOAD_CONFIG_DIRECTORY warning messages? What if any checks do you want to execute if this exception is encountered?
Currently you're overloading of the stream insertion operator is triggering all over your other functions - would it make more sense to have an initialization function for setting these results as fields, and have separate function(s) for managing output? This would better segregate your object construction, initialization, and output; and allow your functions to take arguments.
Can you provide an example binary that would trigger these IMAGE_LOAD_CONFIG_DIRECTORY warning messages? What if any checks do you want to execute if this exception is encountered?
I don't have a binary on hand, sorry. An older calc.exe (from Windows XP or earlier) would probably have the truncated load config, though.
You can see the relevant checks anywhere we test loadConfigSize_, e.g.:
cerr << "Warn: no or short load config, assuming no RFG"
<< "\n";
returnfalse;
}
What I think we want is an additional method, like isTruncatedLoadConfig, which we use to populate both operator json() and operator<< for outputting. Something like:
Ultimately though I'm no longer sure this is a relevant piece of information to expose -- having a truncated load config is semantically equivalent to failing the relevant checks and, apart from some messages on stderr, I'm not sure if it's something we should even report on. But I'd be okay with adding it for the time being.
Right now, we just spit out some warning messages if the
IMAGE_LOAD_CONFIG_DIRECTORY
doesn't exist or is too short to perform some checks, but it'd be nice to include that in the JSON output as well.The text was updated successfully, but these errors were encountered: