Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested previews are only partially visible #35

Open
Stvad opened this issue Jul 9, 2022 · 0 comments
Open

Nested previews are only partially visible #35

Stvad opened this issue Jul 9, 2022 · 0 comments
Labels
bug Something isn't working ux

Comments

@Stvad
Copy link
Collaborator

Stvad commented Jul 9, 2022

If I preview link inside another preview, the internal preview is only partially visible.
This is because the outer preview box is in iframe and constraining what can potentially be visible.

Not entirely sure how to solve this so far. Ideally all tippy instances (even nested ones) would share the same shadow-root-container but that seems impossible with cross origin iframes

Other option is doing something like - internal click only send a signal to a parent, which actually does previews, but that'd require some rearchitecture

image

Also, it seems that nested previews don't work for fragment links because mutation observer doesn't get at the shadow root content

@Stvad Stvad added bug Something isn't working ux labels Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux
Projects
None yet
Development

No branches or pull requests

1 participant