Angular 5 httpInterceptors not firing on fetchMetadata

[alexisread]

Hi, I can get interceptors firing on just the breeze-client but not for odata4. I need them to add a withCredentials header.
Test with commenting out (from your test documentation):
OData4UriBuilder.register();
OData4DataService.register();
config.initializeAdapterInstance('uriBuilder', 'OData4', true);
config.initializeAdapterInstance('dataService', 'OData4', true);
to see any interceptor you've added in be hit.
Is this as the odata4 lib uses a different instance of HttpClient compared to the main app? I've had a play at getting HttpClient injected in the constructor, but don't have the time at the moment to fully debug.

Thanks

[tschettler]

Unfortunately, the olingo-odata4 library uses an httpclient that directly requires http. I have not played around with injecting a custom httpClient yet, but I am planning an update to expose headers through the OData4DataService, Will that work for you?

[alexisread]

Thanks for the very quick response! Yes I think that would work fine for me. Really I'd need to change the Accept header (currently /) and Authorization header (withCredentials: true), so that I can connect to an NTLM/Kerberos API.

[alexisread]

FYI this is how I've done it previously with Jaydata (though Jaydata doesn't support webpack and hasn't been updated in a while, hence the move to breeze).

[tschettler]

Please update to version 0.9.13 and the headers property should now be getting used on all requests. You can access the headers from the adapter instance:

    const ds = <OData4DataService>config.getAdapterInstance('dataService', 'OData4');
    ds.headers.Authorization = 'Basic YWxhZ...';

The adapter uses a specific Accept header for accessing metadata, "application/json;odata.metadata=full". If you need to change the Accept header to something else, you may need to do it after the metadata is retrieved, as the headers property will overwrite any headers used in the adapter.

[alexisread]

Hi, unfortunately while the headers can be set, the underlying xhr request doesn't have the withCredentials tag propagated. Looking into the olingo library, I can see that it was patched for Jaydata (jaystack/jaydata#294) which keeps an olingo fork, but not for olingo itself (awaiting merge apache/olingo-odata4-js@8c2bb6f). So for my use i'll need to maintain an olingo fork, and create a ds.withCredentials adapter property.

Thanks

[tschettler]

I see, would you consider submitting a PR for this?

[alexisread]

Happy to, but it'll take a while to develop as this is very much a side project at work :)

[tschettler]

No problem, I know how that goes. I'll add it to the list, looks like creating a custom httpClient should be doable.

[alexisread]

I've had a look into this, and have it working locally, the patch needs to be in ts-odatajs, in node_modules ie. in olingo-odata4-js. I've created a PR for this, and if accepted, I will add in the withCredentials passthrough option here.

Thanks

[tschettler]

Please update to version 0.9.14, after this you can create a class that extends ODataHttpClient. Override the request method to get access to the request object. From there, you can set the withCredentials property. Register the class with the data adapter using the following:

    const ds = <OData4DataService>config.getAdapterInstance('dataService', 'OData4');
    ds.httpClient = new MyODataHttpClient();